[Bugfix] Fix prompt_logprobs when SamplingParams.detokenize is set to False #5226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! Can you add a test case to avoid future regressions? |
Done. PTAL. |
DarkLight1337
approved these changes
Jun 4, 2024
tlrmchlsmth
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jun 5, 2024
blinkbear
pushed a commit
to blinkbear/vllm
that referenced
this pull request
Jun 6, 2024
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jun 11, 2024
joerunde
pushed a commit
to joerunde/vllm
that referenced
this pull request
Jun 17, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jun 27, 2024
zifeitong
changed the title
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 8, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prompt_logprobsis skipped currently whenSamplingParams.detokenizeis set to True.This will enable a workaround of #4904 if the user only needs prompt_logprobs and not detokenized text.