Bugfix: fix broken of download models from modelscope #5233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuyhwangyh
force-pushed
the
fix_download_from_modelscope
branch
from
7a02025 to
a3fa75d
Compare
liuyhwangyh
changed the title
simon-mo
reviewed
Jun 4, 2024
There was a problem hiding this comment.
This test isn't ran at the moment, and I would prefer this be put inside test_regression if possible
There was a problem hiding this comment.
Moved to test_regression.py
simon-mo
reviewed
Jun 4, 2024
| trust_remote_code=trust_remote_code, | ||
| revision=revision, | ||
| code_revision=code_revision) | ||
| if VLLM_USE_MODELSCOPE: |
There was a problem hiding this comment.
can you use the following pattern?
if VLLM_USE_MODELSCOPE:
from modelscope import AutoConfig
auto_cls = AutoConfig
else:
from transformers import AutoConfig
auto_cls = AutoConfig
config = AutoConfig...
simon-mo
approved these changes
Jun 6, 2024
dtrifiro
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
Jun 10, 2024
) Co-authored-by: mulin.lyh <[email protected]>
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jun 11, 2024
) Co-authored-by: mulin.lyh <[email protected]>
joerunde
pushed a commit
to joerunde/vllm
that referenced
this pull request
Jun 17, 2024
) Co-authored-by: mulin.lyh <[email protected]>
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jun 27, 2024
) Co-authored-by: mulin.lyh <[email protected]>
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 8, 2024
) Co-authored-by: mulin.lyh <[email protected]>
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
) Co-authored-by: mulin.lyh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #4362