Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] Update vision tests #5307

Merged
merged 6 commits into from
Jun 6, 2024
Merged

[CI/Build] Update vision tests #5307

merged 6 commits into from
Jun 6, 2024

Conversation

DarkLight1337
Copy link
Member

This PR moves the LLaVA-specific test code into the model test file. It also cleans up some of the code in preparation for #4199.

@DarkLight1337 DarkLight1337 requested a review from ywang96 June 6, 2024 04:04
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few questions

vllm/multimodal/image.py Show resolved Hide resolved
vllm/multimodal/image.py Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
@DarkLight1337
Copy link
Member Author

Answered

@ywang96 ywang96 enabled auto-merge (squash) June 6, 2024 05:10
@simon-mo simon-mo merged commit 89c9207 into vllm-project:main Jun 6, 2024
88 of 90 checks passed
@DarkLight1337 DarkLight1337 deleted the update-vision-tests branch June 6, 2024 12:09
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request Jun 11, 2024
joerunde pushed a commit to joerunde/vllm that referenced this pull request Jun 17, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 27, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 8, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants