-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ BugFix ] Prompt Logprobs Detokenization #6223
Merged
robertgshaw2-redhat
merged 22 commits into
vllm-project:main
from
neuralmagic:prompt-logprobs-fix
Jul 11, 2024
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
08ce232
fix issue with logprobs
robertgshaw2-redhat 99e9cd8
reimplement in a way that supports chunked pre
robertgshaw2-redhat 01088a0
removed nits
robertgshaw2-redhat a7a04ac
nits
robertgshaw2-redhat a20be23
nit
robertgshaw2-redhat bc40a99
this test is almost passing
robertgshaw2-redhat 5f20d78
tests passing
robertgshaw2-redhat 7fd14b4
format
robertgshaw2-redhat 6a3bd63
add co-author
robertgshaw2-redhat badd8b5
add co-author
robertgshaw2-redhat 2c38423
add co-author
robertgshaw2-redhat af7a0da
Update test_detokenize.py
robertgshaw2-redhat 4f1f8ff
finally got tests passing
robertgshaw2-redhat 64b2ae2
Merge branch 'prompt-logprobs-fix' of https://github.com/neuralmagic/…
robertgshaw2-redhat dbe9747
nits
robertgshaw2-redhat 2fdbc01
format
robertgshaw2-redhat 2084cf5
Update test_detokenize.py
robertgshaw2-redhat b2b0037
Update test_detokenize.py
robertgshaw2-redhat e52fd0b
format
robertgshaw2-redhat a4f382f
Update test_detokenize.py
robertgshaw2-redhat 97a8685
updated buildkite
robertgshaw2-redhat 7b44f2d
Update test-pipeline.yaml
robertgshaw2-redhat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first token should have
prompt_logprobs=None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not going to work with chunked prefill because the second chunk won't have None for the first prompt logprob