[Bugfix] MLPSpeculator: Use ParallelLMHead in tie_weights=False case. #6303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Parnell <[email protected]>
robertgshaw2-redhat
approved these changes
Jul 10, 2024
|
Thanks for the fix! |
mgoin
approved these changes
Jul 10, 2024
adityagoel14
pushed a commit
to adityagoel14/vllm-torchrun-test
that referenced
this pull request
Jul 10, 2024
…vllm-project#6303) Signed-off-by: Thomas Parnell <[email protected]> (cherry picked from commit c38eba3)
dtrifiro
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
Jul 17, 2024
…vllm-project#6303) Signed-off-by: Thomas Parnell <[email protected]>
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
…vllm-project#6303) Signed-off-by: Thomas Parnell <[email protected]>
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
…vllm-project#6303) Signed-off-by: Thomas Parnell <[email protected]> Signed-off-by: Alvant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6302
cc @robertgshaw2-neuralmagic