[Bugfix] Fix hard-coded value of x in context_attention_fwd #6373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Parnell <[email protected]>
WoosukKwon
approved these changes
Jul 13, 2024
dtrifiro
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
Jul 17, 2024
…ject#6373) Signed-off-by: Thomas Parnell <[email protected]>
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
…ject#6373) Signed-off-by: Thomas Parnell <[email protected]>
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
…ject#6373) Signed-off-by: Thomas Parnell <[email protected]> Signed-off-by: Alvant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6332
The prefix prefill code assumes that
x=8but this is only the case for fp16 (e.g., see this line). In certain scenarios it is useful to be able to use the prefix prefill code with fp32 (e.g., to compare logprobs generated by chunked prefill against HF generate in CI tests). The correct value ofxis very easy to extract from thekey_cache.cc @caoshiyi @zhuohan123 @DouHappy