Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][TPU] Fix megacore setting for v5e-litepod #6397

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

WoosukKwon
Copy link
Collaborator

The current code does not correctly set the megacore for TPU-v5e-litepod. This PR fixes the bug.

@WoosukKwon WoosukKwon added the tpu Related to Google TPUs label Jul 12, 2024
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only trigger fastcheck CI to run, which consists only a small and essential subset of tests to quickly catch small errors.

Full CI run is still required to merge this PR so please make sure that you run full CI before merging or if you need more test signals.

To run full CI, you can do one of these:

  • Add ready label to the PR
  • Comment /ready on the PR
  • Enable auto-merge.

🚀

@WoosukKwon WoosukKwon merged commit f8f9ff5 into main Jul 12, 2024
16 of 20 checks passed
@WoosukKwon WoosukKwon deleted the tpu-litepod branch July 12, 2024 22:59
dtrifiro pushed a commit to opendatahub-io/vllm that referenced this pull request Jul 17, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tpu Related to Google TPUs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant