-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] use float32 precision in samplers/test_logprobs.py for comparing with HF #6409
Conversation
Signed-off-by: Thomas Parnell <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Full CI run is still required to merge this PR so once the PR is ready to go, please make sure to run it. If you need all test signals in between PR commits, you can trigger full CI as well. To run full CI, you can do one of these:
🚀 |
/ready |
CI failure looks real - I can reproduce locally on an L4 GPU
Haven't seen that before... |
Signed-off-by: Thomas Parnell <[email protected]>
Head branch was pushed to by a user without write access
I was able to solve the error by halving the number of blocks in the prefix prefill kernel when |
Signed-off-by: Thomas Parnell <[email protected]>
@simon-mo auto-merge got disabled on this one, but now it is good. |
…ring with HF (vllm-project#6409) Signed-off-by: Thomas Parnell <[email protected]>
…ring with HF (vllm-project#6409) Signed-off-by: Thomas Parnell <[email protected]>
…ring with HF (vllm-project#6409) Signed-off-by: Thomas Parnell <[email protected]> Signed-off-by: Alvant <[email protected]>
Fixes #6408
This PR changes the precision in
tests/samplers/test_logprobs.py
fromhalf
tofloat
.This is needed because the test is comparing the actual values of the logprobs against the equivalent outputs from HF. There is precedent established for doing this in other tests (see e.g., here or here).
This change ensures that the test does not fail on an H100 GPU.