Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmark_serving.py to read and write json-datasets, results in UTF8, for better compatibility with Windows #8997

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Update benchmark_serving.py to read and write json-datasets, results in UTF8, for better compatibility with Windows #8997

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6cf066
Update benchmark_serving.py to read and write json-datasets, results …
vlsav Oct 1, 2024
cca24af
Merge pull request #1 from vlsav/vlsav-patch-1-benchmark-utf8
vlsav Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions benchmarks/benchmark_serving.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def sample_sharegpt_requests(
fixed_output_len: Optional[int] = None,
) -> List[Tuple[str, int, int, None]]:
# Load the dataset.
with open(dataset_path) as f:
with open(dataset_path, encoding='utf-8') as f:
dataset = json.load(f)
# Filter out the conversations with less than 2 turns.
dataset = [data for data in dataset if len(data["conversations"]) >= 2]
Expand Down Expand Up @@ -139,7 +139,7 @@ def sample_sonnet_requests(
), "'args.sonnet-input-len' must be greater than 'args.prefix-input-len'."

# Load the dataset.
with open(dataset_path) as f:
with open(dataset_path, encoding='utf-8') as f:
poem_lines = f.readlines()

# Tokenize the poem lines.
Expand Down Expand Up @@ -726,7 +726,7 @@ def main(args: argparse.Namespace):
file_name = args.result_filename
if args.result_dir:
file_name = os.path.join(args.result_dir, file_name)
with open(file_name, "w") as outfile:
with open(file_name, "w", encoding='utf-8') as outfile:
json.dump(result_json, outfile)


Expand Down
Loading