Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Move CONTRIBUTING to docs site #9924

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

russellb
Copy link
Member

@russellb russellb commented Nov 1, 2024

The CONTRIBUTING.md file has some good information for contributors.
It would be nice to have a place to organize additional documentation
aimed at contributors, so move this content over to the docs site to
seed a new docs/source/contributing directory.

Replace CONTRIBUTING.md with a link to the new home for this
content.

Signed-off-by: Russell Bryant [email protected]

Copy link

github-actions bot commented Nov 1, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 1, 2024
CONTRIBUTING.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can directly remove this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it, but it's really common to have this file, so keeping it as a pointer seemed harmless enough to me

:maxdepth: 2
:caption: Contributing

contributing/overview.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest moving this to first one inside Developer Documentation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simon-mo I wasn't really sure what the desired scope of that section was. It mostly looks like Python API documentation with a target audience of people using vllm as a library.

and the Profiling vLLM page that does seem more aligned to the "contributing" section I was proposing here.

and then there's the Dockerfile page that I'm not sure really fits in either one.

in summary, we could have

  • API Documentation -- targeted at people using vllm as a library
  • Contributing -- targeted at people working on the vLLM source

and I wouldn't use "Developer Documentation" in either place, since that's a bit ambiguous between the two personas.

Finally, the last alternative I see would be to keep contributor information out of the docs site completely and keep it in its own directory to be browsed on github. That's another way to keep separation between the personas.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed another commit with the changes I proposed above.

  • move profiling and dockerfile content to the new "Contributing" section
  • rename "Developer Documentation" to "API Documentation"

Copy link
Member

@DarkLight1337 DarkLight1337 Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also move the "vLLM Paged Attention", "Input Processing Pipeline" and "Adding a Multimodal Plugin" pages to "Contributing".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for highlighting those docs. I think this warrants a third section:

  1. API Documentation - API reference documents, primarily aimed at those using vLLM as a library
  2. Design - design docs, discussing how parts of vllm work (more technical)
  3. Contributing - information on how to work with vllm as a developer and contributor (more policy and process oriented)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for highlighting those docs. I think this warrants a third section:

  1. API Documentation - API reference documents, primarily aimed at those using vLLM as a library
  2. Design - design docs, discussing how parts of vllm work (more technical)
  3. Contributing - information on how to work with vllm as a developer and contributor (more policy and process oriented)

just finished organizing into these sections

The `CONTRIBUTING.md` file has some good information for contributors.
It would be nice to have a place to organize additional documentation
aimed at contributors, so move this content over to the docs site to
seed a new `docs/source/contributing` directory.

Replace `CONTRIBUTING.md` with a link to the new home for this
content.

Signed-off-by: Russell Bryant <[email protected]>
Rename the "Developer Documentation" section to "API Documentation"
since that's the majority of the content in this section. Move the
"dockerfile" and "profiling" content over to the new "Contributing"
section, since it's more aligned to that.

Signed-off-by: Russell Bryant <[email protected]>
Conver the old CONTRIBUTING.md file content to rst format, instead.
This will allow the `note` and `important` admonition blocks to be
rendered properly. The content previously used github flavored
markdown specific syntax for an `important` message.

Signed-off-by: Russell Bryant <[email protected]>
This doc is aimed more at people working on vllm itself, so move it
into the contributing section.

Signed-off-by: Russell Bryant <[email protected]>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks for reorganizing the docs!

Some future improvements to think about:

  • Group the pages related to Installation and Deployment to avoid taking up so much space in the sidebar
  • Reorganize the pages under Models (why are Engine Arguments / Performance and Tuning placed under there?)

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 8, 2024 03:54
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 8, 2024
@DarkLight1337 DarkLight1337 merged commit 3a7f15a into vllm-project:main Nov 8, 2024
42 checks passed
Isotr0py pushed a commit to Isotr0py/vllm that referenced this pull request Nov 8, 2024
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
jeejeelee pushed a commit to jeejeelee/vllm that referenced this pull request Nov 11, 2024
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 13, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Maxime Fournioux <[email protected]>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants