-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Move CONTRIBUTING to docs site #9924
[Doc] Move CONTRIBUTING to docs site #9924
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
CONTRIBUTING.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can directly remove this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it, but it's really common to have this file, so keeping it as a pointer seemed harmless enough to me
docs/source/index.rst
Outdated
:maxdepth: 2 | ||
:caption: Contributing | ||
|
||
contributing/overview.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest moving this to first one inside Developer Documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simon-mo I wasn't really sure what the desired scope of that section was. It mostly looks like Python API documentation with a target audience of people using vllm as a library.
and the Profiling vLLM
page that does seem more aligned to the "contributing" section I was proposing here.
and then there's the Dockerfile
page that I'm not sure really fits in either one.
in summary, we could have
- API Documentation -- targeted at people using vllm as a library
- Contributing -- targeted at people working on the vLLM source
and I wouldn't use "Developer Documentation" in either place, since that's a bit ambiguous between the two personas.
Finally, the last alternative I see would be to keep contributor information out of the docs site completely and keep it in its own directory to be browsed on github. That's another way to keep separation between the personas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed another commit with the changes I proposed above.
- move profiling and dockerfile content to the new "Contributing" section
- rename "Developer Documentation" to "API Documentation"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also move the "vLLM Paged Attention", "Input Processing Pipeline" and "Adding a Multimodal Plugin" pages to "Contributing".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for highlighting those docs. I think this warrants a third section:
API Documentation
- API reference documents, primarily aimed at those using vLLM as a libraryDesign
- design docs, discussing how parts of vllm work (more technical)Contributing
- information on how to work with vllm as a developer and contributor (more policy and process oriented)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for highlighting those docs. I think this warrants a third section:
API Documentation
- API reference documents, primarily aimed at those using vLLM as a libraryDesign
- design docs, discussing how parts of vllm work (more technical)Contributing
- information on how to work with vllm as a developer and contributor (more policy and process oriented)
just finished organizing into these sections
The `CONTRIBUTING.md` file has some good information for contributors. It would be nice to have a place to organize additional documentation aimed at contributors, so move this content over to the docs site to seed a new `docs/source/contributing` directory. Replace `CONTRIBUTING.md` with a link to the new home for this content. Signed-off-by: Russell Bryant <[email protected]>
Rename the "Developer Documentation" section to "API Documentation" since that's the majority of the content in this section. Move the "dockerfile" and "profiling" content over to the new "Contributing" section, since it's more aligned to that. Signed-off-by: Russell Bryant <[email protected]>
f919d06
to
c4ae837
Compare
Conver the old CONTRIBUTING.md file content to rst format, instead. This will allow the `note` and `important` admonition blocks to be rendered properly. The content previously used github flavored markdown specific syntax for an `important` message. Signed-off-by: Russell Bryant <[email protected]>
This doc is aimed more at people working on vllm itself, so move it into the contributing section. Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks for reorganizing the docs!
Some future improvements to think about:
- Group the pages related to Installation and Deployment to avoid taking up so much space in the sidebar
- Reorganize the pages under Models (why are Engine Arguments / Performance and Tuning placed under there?)
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Loc Huynh <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
The
CONTRIBUTING.md
file has some good information for contributors.It would be nice to have a place to organize additional documentation
aimed at contributors, so move this content over to the docs site to
seed a new
docs/source/contributing
directory.Replace
CONTRIBUTING.md
with a link to the new home for thiscontent.
Signed-off-by: Russell Bryant [email protected]