Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ximinez/peercharges #1

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Ximinez/peercharges #1

merged 5 commits into from
Jan 16, 2025

Conversation

vlntb
Copy link
Owner

@vlntb vlntb commented Jan 16, 2025

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@ximinez
Improve pseudo-transaction peer message handling:
9efdc55 
* Before: Pseudo-transactions received from a peer will fail the signature
  check, even if they were requested (using TMGetObjectByHash), because
  they have no signature. This causes the peer to be charge for an
  invalid signature.
* After: Pseudo-transactions, are put into the global cache
  (TransactionMaster) only. If the transaction is part of
  a TMTransactions batch, the peer is charged the equivalent of one
  trivial request per transaction. If not, the peer is charged an
  unwanted data fee. These fees will not be a problem in the normal
  course of operations, but should dissuade peers from behaving badly by
  sending a bunch of junk.
@ximinez
Tell the overlay about pseudo transactions, but don't relay them
6ec144e 
* If reduce relay is enabled, it will queue up the tx id for peers that
  also have it enabled so they can ask for it later if they need it.
@ximinez
Log higher resource charges with higher log levels
4c0608d
@ximinez
Include context on (some) resource charges
cd9d55e
@ximinez
Add context to all Peer charges
fb04007
@vlntb vlntb merged commit 1141201 into vlntb:fix/signaturefee-to-unwanteddata Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlntb @ximinez