Correct Edge of Madness summon event. #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this was actually sniffed aswell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
This PR updates the Edge of Madness summon event and associated objects to use sniff data.
Following changes has been made:
Updated Updated Edge of Madness tablets to use the correct gameobject entries. The duplication occurred because entry 180364, guid 28661 wasn't visible in-game, as it existed in 'game_event_object' with an event that the others lacked. Consequently, this object didn't spawn alongside the other three. To "fix" this, someone created new custom entries for all four objects in both gameobject and gameobject_template
Deleted part of code using the duplicate tablet objects
Deleted Edge of Madness tablets from 'game_event_gameobject' as they serve no purpose being stored there.
Deleted part of script making all Edge of Madness tablets able to learn you Mojo Madness recipe. It can now only be learned from one tablet and uses correct gossip option to do so.
Remade the lightning script when summoning any Edge of Madness boss.
Added the missing object Troll Hero Air Portal to display when summoning.
Fixed summoning script to match sniff and videos.
Added roar emote to the Edge of Madness bosses that use it when summoned.
Video with PR applied, don't forget to enable sound:
Madness.mp4
Videos from vanilla:
https://youtu.be/pMy5lCVLy40
https://youtu.be/ohmJCvnRbFs?t=5
https://youtu.be/AfT2HSHRO_Y?t=36
Videos from classic:
https://youtu.be/XLQILLvyM-k?t=28
https://youtu.be/Tzssbk9Mruc?t=13
https://youtu.be/lQl2aV80pU0
https://youtu.be/TgMwr_HkmAU?t=78
https://youtu.be/LN9aPSvy87A
Keep in mind that the event in classic does not look the same as in vanilla. The fire never stops burning in classic and the air/fire portals are 1/3 the size.
Proof
Issues
How2Test
Todo / Checklist