vmap extractor - dont save struct padding to temp files #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a breaking change? Does is necessitate re-extraction of vmaps? |
|
nope. Nothing breaking. The 2 random bytes are written by vmap extractor to the temporary files in /buildings/ - and ignored by vmap assembler because it also used sizeof(WMOLiquidHeader). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
sizeof(WMOLiquidHeader) returns the size of the struct which is padded to 32 bytes.
WMOLiquidHeader only contains 30 bytes of data. So 2 random unused bytes are being stored in each temporary file.
Proof
Issues
How2Test
Todo / Checklist