New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Only allow one transaction at the same time" #2834

Merged

ratkosrb merged 1 commit into vmangos:development from 0blu:strict-sql-fix

Nov 17, 2024

Collaborator

0blu commented Nov 17, 2024

This reverts and fixes commit 5a5c7d1.


          Fix "Only allow one transaction at the same time"

b1895ce

This reverts and fixes commit 5a5c7d1.

0blu added the CPP label

ratkosrb merged commit bd99c9a into vmangos:development

3 checks passed

shudza reviewed

View reviewed changes

src/shared/Database/Database.cpp

@@ @@ -487,7 +486,9 @@ bool Database::CommitTransaction() @@
                       return false;
                   //check if we have pending transaction
-                  ASSERT(m_TransStorage->get()); // if we will get a nested transaction request - we MUST fix code!!!
+                  //ASSERT(m_TransStorage->get());
+                  if (!m_TransStorage->get())

Contributor

shudza Nov 17, 2024

this condtion is already asserted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CPP