Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Érvénytelen addr:city értékek története utólag frissül #3818

Closed
vasony opened this issue Mar 30, 2024 · 3 comments
Closed

Érvénytelen addr:city értékek története utólag frissül #3818

vasony opened this issue Mar 30, 2024 · 3 comments
Labels
bug Something isn't working confirmed Makes sense to implement/fix needs testing Testing is needed before this can be closed

Comments

@vasony
Copy link
Collaborator

vasony commented Mar 30, 2024

https://osm.vasony.hu/housenumber-stats/whole-country/#_stats-invalid-addr-cities

Érvénytelen addr:city értékek története statisztika nem az éjszaki frissítési dátumot tárolja el, hanem az utolsó frissítéskori dátumot veszi.

Tegnap este
2023-03-29-re: 2 db volt

Rányomtam este a frissítésre
Ma reggel
2023-03-29-re: 55 db volt
2023-03-30-ra: 55 db volt

Mentse el az első alkalommal egy stat táblába az értéket aznapra, és az már ne frissüljön az oldal frissítésénél.

@vasony vasony added the bug Something isn't working label Mar 30, 2024
@vmiklos
Copy link
Owner

vmiklos commented Mar 30, 2024

Megoldható, ha jól tippelek, akkor annyi az egész, hogy itt:

osm-gimmisn/src/stats.rs

Lines 595 to 599 in bde38be

tx.execute(
r#"insert into stats_invalid_addr_cities_counts (date, count) values (?1, ?2)
on conflict(date) do update set count = excluded.count"#,
[today, invalids.len().to_string()],
)?;

Az on conflict rész kuka, és ha hibát dob az insert akkor nem csinálunk semmit. (De azért ezt ki is kell, próbálni.)

@vmiklos vmiklos added the confirmed Makes sense to implement/fix label Mar 30, 2024
vmiklos added a commit that referenced this issue Mar 31, 2024
Addresses <#3818>.

Change-Id: I26956a40cc92ba77af14de029292a43a95a9ea9a
vmiklos added a commit that referenced this issue Mar 31, 2024
Addresses <#3818>.

Change-Id: I26956a40cc92ba77af14de029292a43a95a9ea9a
@vmiklos
Copy link
Owner

vmiklos commented Mar 31, 2024

lehet tesztelni, nekem jónak tűnik

@vmiklos vmiklos added the needs testing Testing is needed before this can be closed label Mar 31, 2024
@vasony
Copy link
Collaborator Author

vasony commented Apr 4, 2024

@vasony vasony closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed Makes sense to implement/fix needs testing Testing is needed before this can be closed
Projects
None yet
Development

No branches or pull requests

2 participants