Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

[@core/react] NotSupportedError Failed to construct 'CustomElement': The result must not have attributes #6589

Closed
3 of 9 tasks
astorije-vmware opened this issue Jan 24, 2022 · 7 comments · Fixed by #6593
Closed
3 of 9 tasks

Comments

@astorije-vmware
Copy link

astorije-vmware commented Jan 24, 2022

Describe the bug

I was investigating why breadcrumbs were not working properly in our of our apps where we upgraded Clarity Core from v5.5.4 to v5.6.2. Upon creating a reproducible sandbox, this appeared:

Screen Shot 2022-01-24 at 2 20 40 PM

I don't know if the broken breadcrumbs are a consequence of this (you can see the breadcrumbs underneath looking like "FooBarBaz" instead of "Foo / Bar / Baz") but I did experience this same Failed to construct 'CustomElement' error when I started using CdsCard so it doesn't seem to be an isolated event.

How to reproduce

The error should appear upon loading of: https://codesandbox.io/s/fragrant-pond-zf71n?file=/src/App.tsx

Versions

Clarity project:

  • Clarity Core
  • Clarity Angular/UI

Clarity version:

  • v3.x
  • v4.x
  • v5.6.1 / v5.6.2

Framework:

  • Angular
  • React 17
  • Vue
  • Other:
@astorije-vmware
Copy link
Author

I just noticed this on v5.6.1 as well, so we will downgrade to v5.6.0 for now :(

@coryrylan
Copy link
Contributor

I see the issue, we should have this corrected in the next release.

@astorije-vmware
Copy link
Author

Thanks @coryrylan! I know that's a long shot, but do you have any time estimate? That would help us plan our next steps, but no worries if not :)

@mathisscott
Copy link
Contributor

We just finished a release so our next one is likely to be week after next (two week cadence). Some stuff is going on. So maybe it happens sooner or later. But only by a week either way regardless.

@astorije-vmware
Copy link
Author

Are you talking about v6.0.0-next.3?
Any chance this fix could make it into a v5.6.3 release so we're not stuck on v5.6.0 until v6 is a stable release?

Thank you!

@mathisscott
Copy link
Contributor

If this change is not a breaking change, you can expect it to land in 5.6.3. That said, 5.6.3 isn't going to be out for at least two weeks from now due to our two week release cycle...

coryrylan added a commit to coryrylan/clarity that referenced this issue Jan 25, 2022
Fixes invalid native property initialization causing exception with
certain custom elements.
- closes vmware-archive#6589
- closes vmware-archive#6590

Signed-off-by: Cory Rylan <[email protected]>
coryrylan added a commit to coryrylan/clarity that referenced this issue Jan 25, 2022
Fixes invalid native property initialization causing exception with
certain custom elements.
- closes vmware-archive#6589
- closes vmware-archive#6590

Signed-off-by: Cory Rylan <[email protected]>
coryrylan added a commit that referenced this issue Jan 25, 2022
Fixes invalid native property initialization causing exception with
certain custom elements.
- closes #6589
- closes #6590

Signed-off-by: Cory Rylan <[email protected]>
coryrylan added a commit that referenced this issue Jan 25, 2022
Fixes invalid native property initialization causing exception with
certain custom elements.
- closes #6589
- closes #6590

Signed-off-by: Cory Rylan <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants