This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
feat(form): support a generic control container #4280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnomeontherun
force-pushed
the
forms/generic-container
branch
from
d7261ea to
595fe3a
Compare
hippee-lee
approved these changes
Feb 14, 2020
| // This software is released under MIT license. | ||
| // The full license information can be found in LICENSE in the root directory of this project. | ||
|
|
||
| @import ''; |
There was a problem hiding this comment.
nit: empty import or empty file?
mathisscott
approved these changes
Feb 16, 2020
gnomeontherun
force-pushed
the
forms/generic-container
branch
2 times, most recently
from
303085b to
0c17789
Compare
This implements a new `clr-control-container` component and `clrControl` directive for wrapping potentially any form control to work with Clarity forms. Any controls must implement FormControlAccessor to properly wire up with the forms logic, but it works for internal or third party components. Signed-off-by: Jeremy Wilken <[email protected]>
gnomeontherun
force-pushed
the
forms/generic-container
branch
from
0c17789 to
ef7be50
Compare
|
Any chance this can be back ported to 2.x? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new
clr-control-containercomponent andclrControldirective for wrapping potentially any form control to work with Clarity forms. Any controls must implement FormControlAccessor to properly wire up with the forms logic, but it works for internal or third party components.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
closes: #2886
What is the new behavior?
Does this PR introduce a breaking change?
Other information