Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the missing externalDatabase.host and externalDatabase.port fields #7743

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

brunomedeirosdedalus
Copy link

@brunomedeirosdedalus brunomedeirosdedalus commented Apr 26, 2024

Adding the missing externalDatabase.host and externalDatabase.port fields for values.yaml

Description of the change

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

This PR adds to the values.yaml the missing 'externalDatabase.host' and 'externalDatabase'.port' fields needed to setup and external database.

@vmwclabot
Copy link

@brunomedeirosdedalus, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 8df4faa
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/6707dad5a6af1a00095abcea

@vmwclabot
Copy link

@brunomedeirosdedalus, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@brunomedeirosdedalus
Copy link
Author

There is a lot room for improving here, like adding under externalDatabase, the DB username, name and so on

@vmwclabot
Copy link

@brunomedeirosdedalus, VMware has approved your signed contributor license agreement.

@brunomedeirosdedalus
Copy link
Author

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants