Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go1.17 deprecates GODEBUG=x509ignoreCN=0 #1227

Closed
wilsonehusin opened this issue Apr 1, 2021 · 0 comments · Fixed by #1246
Closed

go1.17 deprecates GODEBUG=x509ignoreCN=0 #1227

wilsonehusin opened this issue Apr 1, 2021 · 0 comments · Fixed by #1246

Comments

@wilsonehusin
Copy link
Contributor

The way we generate CA for integration test isn't fully compliant with CA spec (this is all I remembered, don't quite remember how, will add details later) and go1.15 started enforcing that case which failed our tests. I added GODEBUG=x509ignoreCN=0 because it was only for test at crunch time 😅

To be clear: this isn't a bug in Sonobuoy itself, it's just a test data which needs to be fixed

Deprecation ref here.
@johnSchnake johnSchnake mentioned this issue May 6, 2021
Merged
johnSchnake added a commit that referenced this issue May 6, 2021
@johnSchnake
Don't use x509 common names
4573667 
Use Subject Alternate Names fields instead.

Fixes: #1227

Signed-off-by: John Schnake <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't use x509 common names
1 participant
@wilsonehusin