Fix the file locking issue on Windows #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For completeness we should test interacting with a plugin built with 1.4.2 or TPR as well. |
vuil
approved these changes
Aug 8, 2024
marckhouzam
approved these changes
Aug 8, 2024
- For more details see: vmware-tanzu/tanzu-plugin-runtime#204
anujc25
force-pushed
the
fix-file-locking-issue
branch
from
c02610d to
fd7f66d
Compare
@vuil I built the |
@vuil I have tested this on Mac, Linux and Windows all three and added details for windows in PR description. |
|
Thanks for furnishing the test details. LGTM. |
anujc25
added a commit
to anujc25/tanzu-cli
that referenced
this pull request
Aug 14, 2024
- For more details see: vmware-tanzu/tanzu-plugin-runtime#204
anujc25
added a commit
that referenced
this pull request
Aug 14, 2024
- For more details see: vmware-tanzu/tanzu-plugin-runtime#204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Build the Tanzu CLI for Windows, Mac, Linux with the fix
Verify that CLI can install and run the
packageandspaceplugin (built with older Tanzu Plugin Runtime)Build the
spaceplugin using v1.4.2 version of Tanzu Plugin RuntimeVerify that CLI can install the
spaceplugin (built with newer v1.4.2 Tanzu Plugin Runtime)Windows Tests:
Release note
Additional information
Special notes for your reviewer