Only get VolumeSnapshotClass when DataUpload exists.

Signed-off-by: Xun Jiang <[email protected]>

changelogs/unreleased/7974-blackpiglet

@@ -0,0 +1 @@
+Only get VolumeSnapshotClass when DataUpload exists.

internal/volume/volumes_information.go

@@ -551,6 +551,22 @@ func (v *BackupVolumesInformation) generateVolumeInfoFromPVB() {
 	v.volumeInfos = append(v.volumeInfos, tmpVolumeInfos...)
 }
 
+func (v *BackupVolumesInformation) getVolumeSnapshotClasses(
+	classes *snapshotv1api.VolumeSnapshotClassList,
+) (*snapshotv1api.VolumeSnapshotClassList, error) {
+	if classes != nil {
+		return classes, nil
+	}
+
+	vsClassList := new(snapshotv1api.VolumeSnapshotClassList)
+	if err := v.crClient.List(context.TODO(), vsClassList); err != nil {
+		v.logger.Warnf("Cannot list VolumeSnapshotClass with error %s.", err.Error())
+		return nil, err
+	}
+
+	return vsClassList, nil
+}
+
 // generateVolumeInfoFromDataUpload generate BackupVolumeInfo for DataUpload.
 func (v *BackupVolumesInformation) generateVolumeInfoFromDataUpload() {
 	if !features.IsEnabled(velerov1api.CSIFeatureFlag) {
@@ -559,11 +575,7 @@ func (v *BackupVolumesInformation) generateVolumeInfoFromDataUpload() {
 	}
 
 	tmpVolumeInfos := make([]*BackupVolumeInfo, 0)
-	vsClassList := new(snapshotv1api.VolumeSnapshotClassList)
-	if err := v.crClient.List(context.TODO(), vsClassList); err != nil {
-		v.logger.WithError(err).Errorf("cannot list VolumeSnapshotClass %s", err.Error())
-		return
-	}
+	var vsClassList *snapshotv1api.VolumeSnapshotClassList
 
 	for _, operation := range v.BackupOperations {
 		if operation.Spec.ResourceIdentifier.GroupResource.String() == kuberesource.PersistentVolumeClaims.String() {
@@ -593,6 +605,11 @@ func (v *BackupVolumesInformation) generateVolumeInfoFromDataUpload() {
 				continue
 			}
 
+			vsClassList, err = v.getVolumeSnapshotClasses(vsClassList)
+			if err != nil {
+				return
+			}
+
 			driverUsedByVSClass := ""
 			for index := range vsClassList.Items {
 				if vsClassList.Items[index].Name == dataUpload.Spec.CSISnapshot.SnapshotClass {

internal/volume/volumes_information_test.go

@@ -1310,3 +1310,12 @@ func int64Ptr(val int) *int64 {
 	i := int64(val)
 	return &i
 }
+
+func TestGetVolumeSnapshotClasses(t *testing.T) {
+	volumesInfo := BackupVolumesInformation{}
+	var vsClass snapshotv1api.VolumeSnapshotClassList
+
+	result, err := volumesInfo.getVolumeSnapshotClasses(&vsClass)
+	require.NoError(t, err)
+	require.Equal(t, &vsClass, result)
+}