Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headless services don't get restored properly #168

Closed
skriss opened this issue Oct 31, 2017 · 1 comment · Fixed by #171
Closed

Headless services don't get restored properly #168

skriss opened this issue Oct 31, 2017 · 1 comment · Fixed by #171
Assignees
@nrb
Labels
Bug Help wanted
Milestone
v0.6.0

Comments

@skriss
Copy link
Contributor

skriss commented Oct 31, 2017

The clusterIP for services is always deleted on restores, which has the effect of turning headless services into non-headless. The delete should only be for non-headless.
@skriss skriss added this to the v0.6.0 milestone Oct 31, 2017
@ncdc
Copy link
Contributor

ncdc commented Oct 31, 2017

i.e. don't delete it if the value is None

@nrb nrb self-assigned this Oct 31, 2017
nrb pushed a commit to nrb/velero that referenced this issue Nov 1, 2017
Don't delete 'headless' services
d22907c 
Deleting the clusterIP field when the service should be headless will
cause it to be assigned a new IP on restore; instead it should retain
the headless state after restoration.

Fixes vmware-tanzu#168

Signed-off-by: Nolan Brubaker <[email protected]>
@nrb nrb mentioned this issue Nov 1, 2017
Merged
nrb pushed a commit to nrb/velero that referenced this issue Nov 1, 2017
Don't delete 'headless' services
fb95b55 
Deleting the clusterIP field when the service should be headless will
cause it to be assigned a new IP on restore; instead it should retain
the headless state after restoration.

Fixes vmware-tanzu#168

Signed-off-by: Nolan Brubaker <[email protected]>
nrb pushed a commit to nrb/velero that referenced this issue Nov 1, 2017
Don't delete 'headless' services
7d7f2a5 
Deleting the clusterIP field when the service should be headless will
cause it to be assigned a new IP on restore; instead it should retain
the headless state after restoration.

Fixes vmware-tanzu#168

Signed-off-by: Nolan Brubaker <[email protected]>
nrb pushed a commit to nrb/velero that referenced this issue Nov 1, 2017
Don't delete 'headless' services
d87e8ee 
Deleting the clusterIP field when the service should be headless will
cause it to be assigned a new IP on restore; instead it should retain
the headless state after restoration.

Fixes vmware-tanzu#168

Signed-off-by: Nolan Brubaker <[email protected]>
ncdc pushed a commit to ncdc/velero that referenced this issue Nov 2, 2017
@ncdc
Don't delete 'headless' services
330a050 
Deleting the clusterIP field when the service should be headless will
cause it to be assigned a new IP on restore; instead it should retain
the headless state after restoration.

Fixes vmware-tanzu#168

Signed-off-by: Nolan Brubaker <[email protected]>
(cherry picked from commit d87e8ee)
shubham-pampattiwar pushed a commit to shubham-pampattiwar/velero that referenced this issue Aug 11, 2022
@sseago
Update version string for 1.9.0 (vmware-tanzu#168)
2701b71
shubham-pampattiwar pushed a commit to shubham-pampattiwar/velero that referenced this issue Sep 26, 2022
@sseago
Update version string for 1.9.0 (vmware-tanzu#168)
e8e11fd
kaovilai pushed a commit to kaovilai/velero that referenced this issue Feb 6, 2023
@sseago
Update version string for 1.9.0 (vmware-tanzu#168)
7fd8b40
kaovilai pushed a commit to kaovilai/velero that referenced this issue Mar 16, 2023
@sseago
Update version string for 1.9.0 (vmware-tanzu#168)
42cd992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nrb nrb

Labels
Bug Help wanted
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

Don't delete 'headless' services nrb/velero
3 participants
@ncdc @nrb @skriss