Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to delete / replace backups #212

Closed
wonderhoss opened this issue Nov 23, 2017 · 6 comments · Fixed by #252
Closed

How to delete / replace backups #212

wonderhoss opened this issue Nov 23, 2017 · 6 comments · Fixed by #252
Assignees

Comments

@wonderhoss
Copy link

Hi,

I have a feeling that this is a really stupid question, but I haven't managed to find a conclusive answer in the docs:

How does one go about deleting or overwriting a backup object?
Can it just be deleted from S3 (in our case)?

An ark backup delete subcommand would be useful.

Thanks,

Phil

@ncdc
Copy link
Contributor

ncdc commented Nov 23, 2017 via email

@wonderhoss
Copy link
Author

But to be clear, it is entirely safe to just delete the S3 folder corresponding to the backup?

@ncdc
Copy link
Contributor

ncdc commented Nov 23, 2017 via email

@etiennetremel
Copy link

I also agree with @gargath, it would be nice to have such feature, that would ease deletion of associated snapshots, for now we have to manually look for the ark tag and the creation date added to the snapshot.

@ncdc
Copy link
Contributor

ncdc commented Dec 4, 2017

This is definitely a feature we plan to add. We'd definitely welcome & appreciate pull requests if anyone has time. Otherwise, it's on our roadmap, and we will eventually implement it.

@skriss skriss self-assigned this Dec 14, 2017
@skriss
Copy link
Contributor

skriss commented Dec 14, 2017

I'm working on this ATM.

@ncdc ncdc closed this as completed in #252 Jan 2, 2018
github-actions bot pushed a commit to kaovilai/velero that referenced this issue Oct 24, 2022
kaovilai pushed a commit to kaovilai/velero that referenced this issue Feb 6, 2023
kaovilai pushed a commit to kaovilai/velero that referenced this issue Mar 16, 2023
alromeros pushed a commit to alromeros/velero that referenced this issue Oct 25, 2024
* Generalize tests to check for specific resources in backup

Instead of expecting a specific number of objects backed up
we should check if the objects we care about were backed up,
the check can also catch bugs that we could have missed in case
the number didnt change but for some reason our desired object
wasnt backed up.

Signed-off-by: Shelly Kagan <[email protected]>

* Improve test to check specific pv and pod name

Signed-off-by: Shelly Kagan <[email protected]>

---------

Signed-off-by: Shelly Kagan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants