Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate --default-volumes-to-restic without reinstalling #2781

Closed
Panplumousse opened this issue Jul 31, 2020 · 10 comments · Fixed by #2776
Closed

Activate --default-volumes-to-restic without reinstalling #2781

Panplumousse opened this issue Jul 31, 2020 · 10 comments · Fixed by #2776

Comments

@Panplumousse
Copy link

Panplumousse commented Jul 31, 2020

Describe the problem/challenge you have
Is not really a problem is a question about velero installation

Describe the solution you'd like
I am using velero / restic in production and would like to change the way volumes are backed up.

I would like to activate the option: --default-volumes-to-restic
without reinstalling velero, maybe by modifying the velero "deploy".

Could you tell me how can imake this modification

thank you in advance

  • Velero 1.3.2
@ashish-amarnath
Copy link
Member

@Panplumousse Thanks for asking for this feature.
Have you considered using the --default-volumes-to-restic flag on the velero backup create command to use this feature on a per backup basis instead of enabling it for all the backups?
You can find out more about this on our docs website at https://velero.io/docs/main/restic/ under the "Using the opt-out approach" section

@ashish-amarnath ashish-amarnath added Enhancement/User End-User Enhancement to Velero Needs Product Blocked needing input or feedback from Product labels Aug 4, 2020
@Panplumousse
Copy link
Author

Hello

yes i have check that but i use schedule for backup and i dont know where put this flag option in schedule yaml

@ashish-amarnath
Copy link
Member

Wrt schedules, the --default-volumes-to-restic flag was not getting passed from the velero schedule create command to the BackupSpec I have a PR #2776 that should fix that for you.

@nrb
Copy link
Contributor

nrb commented Aug 6, 2020

To answer the question about modifying the velero deployment, you can use kubectl edit or kubectl patch to modify the Velero deployment's arguments.

velero install currently does not modify deployed Kubernetes objects, and will eventually be deprecated in favor of a new command (velero config) that can.

@Panplumousse
Copy link
Author

Panplumousse commented Aug 8, 2020

@ashish-amarnath
thx for feed back

@nrb
Thx for you answer , but where in deployement i have to put information and witch information , for use --default-volumes-to-restic

thx a lot

@ashish-amarnath
Copy link
Member

@Panplumousse the --default-volumes-to-restic is a command-line flag to the velero container

$ kubectl -n velero get deploy velero -ojson | jq .spec.template.spec.containers[0].args
[
  "server",
  "--features=",
  "--default-volumes-to-restic=true"
]

$ kubectl -n velero get deploy velero -ojson | jq .spec.template.spec.containers[0].args[2]
"--default-volumes-to-restic=true"

@ashish-amarnath ashish-amarnath added Question and removed Enhancement/User End-User Enhancement to Velero Needs Product Blocked needing input or feedback from Product labels Aug 8, 2020
@Panplumousse
Copy link
Author

@ashish-amarnath thx for your feed back

from which version of velero this functionality is present I am currently in 1.3.2
and when i try to modify deploy i receive this error :

Error: unknown flag: --default-volumes-to-restic
Usage:
velero server [flags] ....

thx a lot

@ashish-amarnath
Copy link
Member

ashish-amarnath commented Aug 10, 2020 via email

@Panplumousse
Copy link
Author

@ashish-amarnath ok thx a lot

@ashish-amarnath
Copy link
Member

@Panplumousse I don't think there is any further action item on this PR. I'll close this out. Feel free to reach out if you have more questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants