Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post hooks should always fire regardless of item action failures #511

Closed
ncdc opened this issue May 22, 2018 · 1 comment
Closed

Post hooks should always fire regardless of item action failures #511

ncdc opened this issue May 22, 2018 · 1 comment
Labels
Bug

Comments

@ncdc
Copy link
Contributor

ncdc commented May 22, 2018

Scenario:

  1. pre-hook calls fsfreeze
  2. some item action fails
  3. return error immediately

This leaves the pod in an unusable state, since the file system is frozen.
@ncdc
Copy link
Contributor Author

ncdc commented May 22, 2018

WDYT @skriss?

@ncdc ncdc mentioned this issue May 22, 2018
Closed
This was referenced May 22, 2018
Merged
Merged
@ncdc ncdc closed this as completed in #514 May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ncdc