Run post-hooks even if backup actions fail #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlpett
force-pushed
the
post-hooks-after-error
branch
from
9919150 to
b66b90c
Compare
ncdc
suggested changes
May 23, 2018
pkg/backup/item_backupper.go
Outdated
| backupErrs := make([]error, 0) | ||
| err = ib.executeActions(log, obj, groupResource, name, namespace, metadata) | ||
| if err != nil { | ||
| log.WithError(err).Error("Error executing backup actions") |
There was a problem hiding this comment.
I'd change "backup" to "item"
Signed-off-by: Calle Pettersson <[email protected]>
carlpett
force-pushed
the
post-hooks-after-error
branch
from
b66b90c to
b2ec87f
Compare
|
|
LGTM |
ncdc
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #511
This pulls all the action execution out into a new function (should there be matching changes in unit tests for this?), then ensures post-action hooks are run regardless of errors in the actions, and then returns any errors (including any in the post hook)