Fix restore namespace remapping bug #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skriss
force-pushed
the
fix-ns-mapping
branch
2 times, most recently
from
c6714aa to
ce61ce0
Compare
Signed-off-by: Steve Kriss <[email protected]>
skriss
force-pushed
the
fix-ns-mapping
branch
from
ce61ce0 to
55c038a
Compare
ncdc
reviewed
Nov 2, 2017
| gv := schema.GroupVersion{Group: "", Version: "v1"} | ||
| dynamicFactory.On("ClientForGroupVersionResource", gv, resource, expectedNS).Return(resourceClient, nil) | ||
|
|
||
| log, _ := testlogger.NewNullLogger() |
There was a problem hiding this comment.
arktest.NewLogger(), move it down to line 326 directly
There was a problem hiding this comment.
context.logger is a *logrus.Logger, not a *logrus.LogEntry -- you want me to change it to a FieldLogger as part of this PR?
ncdc
changed the title
|
Oh, never mind for now.
…On Thu, Nov 2, 2017 at 1:52 PM Steve Kriss ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkg/restore/restore_test.go
<#179 (comment)>:
> + fileSystem = newFakeFileSystem().WithFile("bak/resources/configmaps/namespaces/ns-1/cm-1.json", newTestConfigMap().WithNamespace("ns-1").ToJSON())
+ expectedNS = "ns-2"
+ expectedObjs = toUnstructured(newTestConfigMap().WithNamespace("ns-2").WithArkLabel("").ConfigMap)
+ )
+
+ resourceClient := &FakeDynamicClient{}
+ for i := range expectedObjs {
+ resourceClient.On("Create", &expectedObjs[i]).Return(&expectedObjs[i], nil)
+ }
+
+ dynamicFactory := &FakeDynamicFactory{}
+ resource := metav1.APIResource{Name: "configmaps", Namespaced: true}
+ gv := schema.GroupVersion{Group: "", Version: "v1"}
+ dynamicFactory.On("ClientForGroupVersionResource", gv, resource, expectedNS).Return(resourceClient, nil)
+
+ log, _ := testlogger.NewNullLogger()
context.logger is a *logrus.Logger, not a *logrus.LogEntry -- you want me
to change it to a FieldLogger as part of this PR?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#179 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAABYuXo6GrntmzgqoPik714a6UzBiA6ks5sygFjgaJpZM4QQCev>
.
|
|
OK - good change to make in general, that interface covers both the Logger and the LogEntry, but we can circle back. |
shubham-pampattiwar
added a commit
to shubham-pampattiwar/velero
that referenced
this pull request
Aug 11, 2022
…-tanzu#179) * improve datamover backup performance * remove minor logs * remove unrelated changes * add vol-snap-mover deps * fix logrusr dep issue * fix via go mod tidy Co-authored-by: Shubham Pampattiwar <[email protected]>
shubham-pampattiwar
added a commit
to shubham-pampattiwar/velero
that referenced
this pull request
Sep 26, 2022
…-tanzu#179) * improve datamover backup performance * remove minor logs * remove unrelated changes * add vol-snap-mover deps * fix logrusr dep issue * fix via go mod tidy Co-authored-by: Shubham Pampattiwar <[email protected]>
kaovilai
pushed a commit
to kaovilai/velero
that referenced
this pull request
Feb 6, 2023
…-tanzu#179) * improve datamover backup performance * remove minor logs * remove unrelated changes * add vol-snap-mover deps * fix logrusr dep issue * fix via go mod tidy Co-authored-by: Shubham Pampattiwar <[email protected]>
kaovilai
pushed a commit
to kaovilai/velero
that referenced
this pull request
Mar 16, 2023
…-tanzu#179) * improve datamover backup performance * remove minor logs * remove unrelated changes * add vol-snap-mover deps * fix logrusr dep issue * fix via go mod tidy Co-authored-by: Shubham Pampattiwar <[email protected]>
alromeros
pushed a commit
to alromeros/velero
that referenced
this pull request
Oct 25, 2024
…zu#179) Bumps [github.com/vmware-tanzu/velero](https://github.com/vmware-tanzu/velero) from 1.10.0 to 1.11.1. - [Release notes](https://github.com/vmware-tanzu/velero/releases) - [Changelog](https://github.com/vmware-tanzu/velero/blob/main/CHANGELOG.md) - [Commits](vmware-tanzu/velero@v1.10.0...v1.11.1) --- updated-dependencies: - dependency-name: github.com/vmware-tanzu/velero dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kriss [email protected]
Fixes: #176