Add status column to get BSL output #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlisia <[email protected]>
|
Or maybe This is because when the BSL gets created on the client side it isn't validated then, that only happens when the BSL controller runs (see: #2490). |
skriss
reviewed
May 12, 2020
|
|
||
| status := location.Status.Phase | ||
| if status == "" { | ||
| status = velerov1api.BackupStorageLocationPhaseAvailable |
There was a problem hiding this comment.
I'd display this as <Unknown> or something along those lines, since we don't yet know if it's available.
Even if we define a third phase of Unknown, new CRs could still have an empty phase (until we add defaulting to our CRD specs), so I do think it makes sense to check for and handle an empty status.phase field here.
There was a problem hiding this comment.
Yes, make sense. Looks like this now:
Signed-off-by: Carlisia <[email protected]>
2 tasks
ashish-amarnath
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #2489.
Question
It seems to me as arbitrary to specify an empty status with
Availableas it would be withUnavailable- here: https://github.com/vmware-tanzu/velero/compare/master...carlisia:c-2489-bsl-column?expand=1#diff-c73073c993c3249edf0a5d8b6d30fa87R64Should there be a third phase, maybe status
Unknown? I'm not super set on this, we could make it available/unavailable.Signed-off-by: Carlisia [email protected]