Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft design doc for restoring API group version by priority level #3050

Merged
merged 7 commits into from
Dec 8, 2020
Merged

Draft design doc for restoring API group version by priority level #3050

merged 7 commits into from
Dec 8, 2020

Conversation

codegold79
Copy link
Contributor

@codegold79 codegold79 commented Oct 30, 2020 •
edited
Loading

Add design doc draft for restoring API group version by priority level.
Addresses issue #2551.

Signed-off-by: F. Gold [email protected]

@codegold79 codegold79 changed the title Draft design doc for restoring API group version by priority level (#2551) Draft design doc for restoring API group version by priority level Oct 30, 2020
@codegold79 codegold79 force-pushed the design-doc-restore-with-enableAPIGroupVerisons-2551 branch from a9f88eb to 67a983b Compare October 30, 2020 23:47
@nrb nrb added the Area/Design Design Documents label Nov 2, 2020
nrb
nrb suggested changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This proposal looks pretty solid to me! I do have some clarifications I think we can make, but on the whole I'm comfortable with the direction.

@vmware-tanzu/velero-maintainers please also take a look and see what you think.

design/restore-with-EnableAPIGroupVersions-feature.md Outdated Show resolved Hide resolved
design/restore-with-EnableAPIGroupVersions-feature.md Outdated Show resolved Hide resolved
design/restore-with-EnableAPIGroupVersions-feature.md Outdated Show resolved Hide resolved
design/restore-with-EnableAPIGroupVersions-feature.md Outdated Show resolved Hide resolved
design/restore-with-EnableAPIGroupVersions-feature.md Outdated Show resolved Hide resolved
@codegold79
Copy link
Contributor Author

This proposal looks pretty solid to me! I do have some clarifications I think we can make, but on the whole I'm comfortable with the direction.

Thank you @nrb for your careful review and very on-target and helpful comments.

While writing out the code, I realized I reference the incorrect Kubernetes version sorting function. I have also decided to change some of the methods and variable names. I'll be sure to update the design doc tomorrow with yours and my updates.

@github-actions github-actions bot requested a review from nrb November 21, 2020 04:42
nrb
nrb suggested changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 1 change to request and two questions. Thanks for the very detailed proposal! This is looking very solid!

design/restore-with-EnableAPIGroupVersions-feature.md Outdated Show resolved Hide resolved
design/restore-with-EnableAPIGroupVersions-feature.md Outdated Show resolved Hide resolved
design/restore-with-EnableAPIGroupVersions-feature.md Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from nrb December 2, 2020 22:41
@codegold79 codegold79 mentioned this pull request Dec 4, 2020
Merged
ashish-amarnath
ashish-amarnath approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@ashish-amarnath ashish-amarnath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed proposal.
This LGTM.

@nrb Handing this to you for sign-off and merge.

nrb
nrb approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these revisions and all your hard work on this!

@nrb nrb merged commit b6eae33 into vmware-tanzu:main Dec 8, 2020
@georgettica georgettica mentioned this pull request Dec 23, 2020
Closed
georgettica pushed a commit to georgettica/velero that referenced this pull request Dec 23, 2020
@codegold79 @georgettica
Draft design doc for restoring API group version by priority level (v…
bf7fad9 
…mware-tanzu#3050)

* Draft design doc for restoring API group version by priority level

Signed-off-by: F. Gold <[email protected]>

* Make changes per @jenting review and use filepath to join paths

Signed-off-by: F. Gold <[email protected]>

* Update design doc with config map and k8s version priorities

Signed-off-by: F. Gold <[email protected]>

* Edit k8s doc URL per @jenting's review comment

Signed-off-by: F. Gold <[email protected]>

* Editorial changes

Signed-off-by: F. Gold <[email protected]>

* Changes per @nrb PR review and other edits

Signed-off-by: F. Gold <[email protected]>

* Update Status.FormatVersion check sections and minor edits

Signed-off-by: F. Gold <[email protected]>
georgettica pushed a commit to georgettica/velero that referenced this pull request Jan 26, 2021
@codegold79 @georgettica
Draft design doc for restoring API group version by priority level (v…
b6518a7 
…mware-tanzu#3050)

* Draft design doc for restoring API group version by priority level

Signed-off-by: F. Gold <[email protected]>

* Make changes per @jenting review and use filepath to join paths

Signed-off-by: F. Gold <[email protected]>

* Update design doc with config map and k8s version priorities

Signed-off-by: F. Gold <[email protected]>

* Edit k8s doc URL per @jenting's review comment

Signed-off-by: F. Gold <[email protected]>

* Editorial changes

Signed-off-by: F. Gold <[email protected]>

* Changes per @nrb PR review and other edits

Signed-off-by: F. Gold <[email protected]>

* Update Status.FormatVersion check sections and minor edits

Signed-off-by: F. Gold <[email protected]>
vadasambar pushed a commit to vadasambar/velero that referenced this pull request Feb 3, 2021
@codegold79
Draft design doc for restoring API group version by priority level (v…
999563e 
…mware-tanzu#3050)

* Draft design doc for restoring API group version by priority level

Signed-off-by: F. Gold <[email protected]>

* Make changes per @jenting review and use filepath to join paths

Signed-off-by: F. Gold <[email protected]>

* Update design doc with config map and k8s version priorities

Signed-off-by: F. Gold <[email protected]>

* Edit k8s doc URL per @jenting's review comment

Signed-off-by: F. Gold <[email protected]>

* Editorial changes

Signed-off-by: F. Gold <[email protected]>

* Changes per @nrb PR review and other edits

Signed-off-by: F. Gold <[email protected]>

* Update Status.FormatVersion check sections and minor edits

Signed-off-by: F. Gold <[email protected]>
dharmab pushed a commit to dharmab/velero that referenced this pull request May 25, 2021
@codegold79 @dharmab
Draft design doc for restoring API group version by priority level (v…
a35bd6e 
…mware-tanzu#3050)

* Draft design doc for restoring API group version by priority level

Signed-off-by: F. Gold <[email protected]>

* Make changes per @jenting review and use filepath to join paths

Signed-off-by: F. Gold <[email protected]>

* Update design doc with config map and k8s version priorities

Signed-off-by: F. Gold <[email protected]>

* Edit k8s doc URL per @jenting's review comment

Signed-off-by: F. Gold <[email protected]>

* Editorial changes

Signed-off-by: F. Gold <[email protected]>

* Changes per @nrb PR review and other edits

Signed-off-by: F. Gold <[email protected]>

* Update Status.FormatVersion check sections and minor edits

Signed-off-by: F. Gold <[email protected]>
ywk253100 pushed a commit to ywk253100/velero that referenced this pull request Jun 29, 2021
@codegold79 @ywk253100
Draft design doc for restoring API group version by priority level (v…
340611c 
…mware-tanzu#3050)

* Draft design doc for restoring API group version by priority level

Signed-off-by: F. Gold <[email protected]>

* Make changes per @jenting review and use filepath to join paths

Signed-off-by: F. Gold <[email protected]>

* Update design doc with config map and k8s version priorities

Signed-off-by: F. Gold <[email protected]>

* Edit k8s doc URL per @jenting's review comment

Signed-off-by: F. Gold <[email protected]>

* Editorial changes

Signed-off-by: F. Gold <[email protected]>

* Changes per @nrb PR review and other edits

Signed-off-by: F. Gold <[email protected]>

* Update Status.FormatVersion check sections and minor edits

Signed-off-by: F. Gold <[email protected]>
gyaozhou pushed a commit to gyaozhou/velero-read that referenced this pull request May 14, 2022
@codegold79 @gyaozhou
Draft design doc for restoring API group version by priority level (v…
b6a6754 
…mware-tanzu#3050)

* Draft design doc for restoring API group version by priority level

Signed-off-by: F. Gold <[email protected]>

* Make changes per @jenting review and use filepath to join paths

Signed-off-by: F. Gold <[email protected]>

* Update design doc with config map and k8s version priorities

Signed-off-by: F. Gold <[email protected]>

* Edit k8s doc URL per @jenting's review comment

Signed-off-by: F. Gold <[email protected]>

* Editorial changes

Signed-off-by: F. Gold <[email protected]>

* Changes per @nrb PR review and other edits

Signed-off-by: F. Gold <[email protected]>

* Update Status.FormatVersion check sections and minor edits

Signed-off-by: F. Gold <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenting jenting jenting left review comments

@ashish-amarnath ashish-amarnath ashish-amarnath approved these changes

@nrb nrb nrb approved these changes

@carlisia carlisia Awaiting requested review from carlisia

@zubron zubron Awaiting requested review from zubron

Assignees

@codegold79 codegold79

Labels
Area/Design Design Documents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codegold79 @nrb @ashish-amarnath @jenting