Filter on resources that support get & delete #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncdc
reviewed
May 14, 2018
pkg/discovery/helper.go
Outdated
| @@ -109,7 +109,7 @@ func (h *helper) Refresh() error { | |||
|
|
|||
| h.resources = discovery.FilteredBy( | |||
| discovery.ResourcePredicateFunc(func(groupVersion string, r *metav1.APIResource) bool { | |||
There was a problem hiding this comment.
@nrb if you wanted to, you could extract this into a separate function, and then unit test it by providing different APIResources and ensuring that it returns true if and only if the resource supports all 4 verbs.
There was a problem hiding this comment.
That would make me a bit more confident in the change. I'll look into this.
ncdc
reviewed
May 15, 2018
| expected bool | ||
| }{ | ||
| { | ||
| name: "resource that supports list, create, get, delete", |
There was a problem hiding this comment.
Can you do 1 more that has this same set of 4 but in a different order? Also please have at least 1 test where there are additional Verbs such as update, patch, and deletecollection.
Some resources use GET for listing, which resulted in errors. Signed-off-by: Nolan Brubaker <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some resources use GET for listing, which resulted in errors.
Fixes #475
Signed-off-by: Nolan Brubaker [email protected]