Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update storage sync docs to note that failed backups are not included #4902

Closed
wants to merge 1 commit into from

Conversation

a-mccarthy
Copy link
Contributor

Signed-off-by: Abigail McCarthy [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

This updates the object storage syncing docs to include a message that failed or partially failed backups will not be removed by Velero.

Does your change fix a particular issue?

Fixes #4483

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@a-mccarthy a-mccarthy added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label May 9, 2022
@a-mccarthy a-mccarthy requested review from skriss and removed request for skriss May 9, 2022 17:24
@github-actions github-actions bot requested review from jenting and sseago May 9, 2022 17:24
@a-mccarthy a-mccarthy requested review from reasonerjt and removed request for jenting May 9, 2022 17:26
@codecov-commenter
Copy link

Codecov Report

Merging #4902 (183ead3) into main (db99b6e) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4902      +/-   ##
==========================================
- Coverage   41.70%   41.65%   -0.05%     
==========================================
  Files         204      204              
  Lines       18040    18040              
==========================================
- Hits         7523     7515       -8     
- Misses       9956     9963       +7     
- Partials      561      562       +1     
Impacted Files Coverage Δ
pkg/restore/restore.go 66.02% <0.00%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db99b6e...183ead3. Read the comment docs.

@a-mccarthy
Copy link
Contributor Author

closing in favor of #4729

@a-mccarthy a-mccarthy closed this May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Failed/PartiallyFailed Orphaned backup will not be removed by ObjectStorageSync
2 participants