Check restore Phase before downloading logs #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a reasonable fix? I added the logic to the |
ncdc
reviewed
May 16, 2018
pkg/cmd/cli/restore/logs.go
Outdated
| return err | ||
| } | ||
| if r.Status.Phase != v1.RestorePhaseCompleted { | ||
| err = errors.Errorf("Restore %s is not yet complete.") |
There was a problem hiding this comment.
I would say "unable to retrieve logs because restore is not yet complete." I don't think we need to include the name of the restore.
|
@nrb yes, this is reasonable, thanks. |
nrb
force-pushed
the
fix-477
branch
2 times, most recently
from
db214fe to
257262f
Compare
skriss
reviewed
May 17, 2018
pkg/cmd/cli/restore/logs.go
Outdated
| return err | ||
| } | ||
| if r.Status.Phase != v1.RestorePhaseCompleted { | ||
| err = errors.Errorf("unable to retrieve logs because restore is not complete") |
There was a problem hiding this comment.
errors.New(...) since it's not a format string, and I'd probably just return the error here and change L93 to a return nil.
There was a problem hiding this comment.
+1 to returning here
I'm almost always in favor of Errorf 100% of the time even if there aren't format strings - saves you the time of having to replace New with Errorf if you do decide you need formatted vars
Signed-off-by: Nolan Brubaker <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #477
Signed-off-by: Nolan Brubaker [email protected]