-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annotation "pv.kubernetes.io/migrated-to" for CSI checking. #5181
Merged
reasonerjt
merged 1 commit into
vmware-tanzu:main
from
blackpiglet:restic-volume-path-change
Aug 8, 2022
Merged
Add annotation "pv.kubernetes.io/migrated-to" for CSI checking. #5181
reasonerjt
merged 1 commit into
vmware-tanzu:main
from
blackpiglet:restic-volume-path-change
Aug 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Dependencies
Pull requests that update a dependency file
has-unit-tests
labels
Aug 4, 2022
blackpiglet
force-pushed
the
restic-volume-path-change
branch
from
August 4, 2022 14:53
04db3c9
to
6e94626
Compare
blackpiglet
force-pushed
the
restic-volume-path-change
branch
3 times, most recently
from
August 4, 2022 16:21
b597978
to
6079636
Compare
Codecov Report
@@ Coverage Diff @@
## main #5181 +/- ##
==========================================
+ Coverage 41.25% 41.61% +0.35%
==========================================
Files 212 215 +3
Lines 18663 18620 -43
==========================================
+ Hits 7700 7749 +49
+ Misses 10389 10294 -95
- Partials 574 577 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
blackpiglet
force-pushed
the
restic-volume-path-change
branch
2 times, most recently
from
August 5, 2022 01:24
11e3d89
to
bad893b
Compare
reasonerjt
reviewed
Aug 5, 2022
blackpiglet
force-pushed
the
restic-volume-path-change
branch
4 times, most recently
from
August 5, 2022 22:55
ba868db
to
7bd9b4e
Compare
github-actions
bot
removed
the
Dependencies
Pull requests that update a dependency file
label
Aug 5, 2022
blackpiglet
force-pushed
the
restic-volume-path-change
branch
from
August 5, 2022 23:33
7bd9b4e
to
43f1ab8
Compare
Verified with following test cases:
|
blackpiglet
force-pushed
the
restic-volume-path-change
branch
2 times, most recently
from
August 6, 2022 13:08
8dfe259
to
3d5d802
Compare
ywk253100
reviewed
Aug 8, 2022
ywk253100
reviewed
Aug 8, 2022
1. Also checking annotation "pv.kubernetes.io/migrated-to" to find out whether volume is provisioned by CSI. 2. Add UT cases. Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
force-pushed
the
restic-volume-path-change
branch
from
August 8, 2022 02:59
3d5d802
to
7af1e23
Compare
ywk253100
approved these changes
Aug 8, 2022
reasonerjt
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xun Jiang [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #5149
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.