Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.9 cherry-pick]Add annotation "pv.kubernetes.io/migrated-to" for CSI checking. #5186

Conversation

blackpiglet
Copy link
Contributor

  1. Also checking annotation "pv.kubernetes.io/migrated-to" to find out whether volume is provisioned by CSI.
  2. Add UT cases.

Signed-off-by: Xun Jiang [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #5149

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

1. Also checking annotation "pv.kubernetes.io/migrated-to" to find out whether volume is provisioned by CSI.
2. Add UT cases.

Signed-off-by: Xun Jiang <[email protected]>
@blackpiglet blackpiglet force-pushed the 1.9-restic-volume-path-check branch from c6bcdb9 to 5838e35 Compare August 8, 2022 04:55
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

Merging #5186 (5838e35) into release-1.9 (56eb492) will decrease coverage by 0.01%.
The diff coverage is 55.55%.

@@               Coverage Diff               @@
##           release-1.9    #5186      +/-   ##
===============================================
- Coverage        41.34%   41.33%   -0.02%     
===============================================
  Files              211      211              
  Lines            18438    18433       -5     
===============================================
- Hits              7624     7619       -5     
  Misses           10241    10241              
  Partials           573      573              
Impacted Files Coverage Δ
pkg/controller/pod_volume_restore_controller.go 22.85% <0.00%> (+0.73%) ⬆️
pkg/util/kube/utils.go 73.79% <64.28%> (-1.59%) ⬇️
pkg/controller/pod_volume_backup_controller.go 44.06% <100.00%> (+0.39%) ⬆️
pkg/restore/restore.go 64.06% <0.00%> (-0.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qiuming-best qiuming-best merged commit 8487585 into vmware-tanzu:release-1.9 Aug 8, 2022
@blackpiglet blackpiglet deleted the 1.9-restic-volume-path-check branch October 15, 2022 04:01
@blackpiglet blackpiglet mentioned this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants