change CSISnapshotTimeout from pointer to normal variable #5294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleverhu
force-pushed
the
change-CSISnapshotTimeout-to-normal-var
branch
from
97adf93 to
a636bc3
Compare
cleverhu
changed the title
Codecov Report
@@ Coverage Diff @@
## main #5294 +/- ##
==========================================
+ Coverage 40.69% 40.72% +0.02%
==========================================
Files 232 232
Lines 20231 20231
==========================================
+ Hits 8234 8239 +5
+ Misses 11398 11393 -5
Partials 599 599
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: cleverhu <[email protected]>
cleverhu
force-pushed
the
change-CSISnapshotTimeout-to-normal-var
branch
from
a636bc3 to
067a3ec
Compare
qiuming-best
approved these changes
Sep 15, 2022
reasonerjt
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
I'm sorry that I accidentally wrote the time as a pointer. I have tested that both pointers and normal variables are valid. I don't know what is the essential difference between them, but I think it's better to keep consistent with the TTL above.
change CSISnapshotTimeout from pointer to normal var.
Does your change fix a particular issue?
Fixes None
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.