rename restic-init-container to ark-restic-restore-helper #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncdc
reviewed
Jun 11, 2018
pkg/restore/restic_restore_action.go
Outdated
| @@ -66,7 +66,7 @@ func (a *resticRestoreAction) Execute(obj runtime.Unstructured, restore *api.Res | |||
|
|
|||
| initContainer := corev1.Container{ | |||
| Name: restic.InitContainer, | |||
| Image: "gcr.io/heptio-images/restic-init-container:latest", | |||
| Image: "gcr.io/heptio-images/ark-restic-restore-helper:latest", | |||
There was a problem hiding this comment.
TODO we can't hard-code latest here. We could have it match ark's version. We may want to have a command line flag to specify the full image spec for this that override's ark's version.
Signed-off-by: Steve Kriss <[email protected]>
skriss
force-pushed
the
rename-init-container
branch
from
e91a81d to
81520a9
Compare
|
Thanks LGTM |
|
Actually since we aren't going to be setting |
|
can we just grab buildinfo.Version? That's an easy change, and can leave TODO for cmd-line flag |
|
That helps with the tag but not the rest of the image URL. But it's a good start, so let's do it. And have the cli flag before we cut 0.9 final. |
skriss
force-pushed
the
rename-init-container
branch
from
7c8a7c4 to
78b3feb
Compare
ncdc
reviewed
Jun 11, 2018
pkg/restore/restic_restore_action.go
Outdated
| tag = "latest" | ||
| } | ||
|
|
||
| return fmt.Sprintf("gcr.io/heptio-images/ark-restic-restore-helper:%s", tag) |
There was a problem hiding this comment.
urgh. cut and failed to paste :/
…iner Signed-off-by: Steve Kriss <[email protected]>
skriss
force-pushed
the
rename-init-container
branch
from
78b3feb to
d7134b1
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kriss [email protected]