Use ResticRepository's resticIdentifier field as the source of truth for repo IDs #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skriss
force-pushed
the
move-repo-id-source
branch
2 times, most recently
from
d211da2 to
cf52df8
Compare
|
last commit lgtm |
Signed-off-by: Steve Kriss <[email protected]>
skriss
force-pushed
the
move-repo-id-source
branch
from
cf52df8 to
f2072e5
Compare
|
rebased, ready for merge. |
nrb
approved these changes
Jun 20, 2018
ncdc
reviewed
Jun 20, 2018
| @@ -84,22 +84,41 @@ func resultsKey(ns, name string) string { | |||
| return fmt.Sprintf("%s/%s", ns, name) | |||
| } | |||
|
|
|||
| func getRepo(repoLister arkv1listers.ResticRepositoryLister, ns, name string) (*arkv1api.ResticRepository, error) { | |||
| repo, err := repoLister.ResticRepositories(ns).Get(name) | |||
| if apierrors.IsNotFound(err) { | |||
There was a problem hiding this comment.
Do we get any benefit by distinguishing the kind of error here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #532 , only the last commit is new.
This PR:
RepoPrefixfield onPodVolumeBackupandPodVolumeRestorewith aRepoIdentifierfield, which contains the full restic repo identifier (populated by the Ark server by pulling from the relevantResticRepositoryCR)repoPrefixfield from thepkg/restic/repositoryManagerand instead sources repos' identifiers from theResticRepositoryCRs (paving the way for supporting heterogeneous restic backends - no need for them all to be the same, or to be AWS/Azure/GCP anymore)PodVolumeRestore, similarly to for backups