require namespace for backups/etc. to exist at server startup #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Kriss <[email protected]>
skriss
changed the title
|
testing looks OK to me. |
|
Should probably include updated quickstart docs with this. |
In what way? |
|
@nrb not sure which docs would need updated here? |
|
I was thinking listing it here https://github.com/heptio/ark/blob/master/docs/quickstart.md#prerequisites |
|
I don't think it's necessary there - this is really only relevant if (a) you're trying to set up a read-only Ark role, per OP, or (b) you're storing backups/restores/schedules/etc. in a different namespace than you're running the Ark server. In the quickstart, everything is in the same namespace, and applying the prereqs file creates it before deploying anything. |
|
Ah, I missed it in my grep of the prereqs YAML. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kriss [email protected]
Fixes #673
Still needs to be tested.