Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrating to sdk/resourcemanager/**/arm** from services/**/mgmt/** #7596

Merged
merged 1 commit into from
Apr 15, 2024
Merged

migrating to sdk/resourcemanager/**/arm** from services/**/mgmt/** #7596

merged 1 commit into from
Apr 15, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Mar 30, 2024

Please add a summary of your change

migrating to sdk/resourcemanager/**/arm** from services/**/mgmt/**

Following https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/MIGRATION_GUIDE.md

Does your change fix a particular issue?

No

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@github-actions github-actions bot added Dependencies Pull requests that update a dependency file has-unit-tests has-changelog labels Mar 30, 2024
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.88%. Comparing base (3d6dab0) to head (704e587).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7596      +/-   ##
==========================================
+ Coverage   61.84%   61.88%   +0.04%     
==========================================
  Files         265      266       +1     
  Lines       29356    29456     +100     
==========================================
+ Hits        18155    18230      +75     
- Misses       9913     9934      +21     
- Partials     1288     1292       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 marked this pull request as ready for review March 30, 2024 12:23
@github-actions github-actions bot requested review from sseago and ywk253100 March 30, 2024 12:23
@mmorel-35 mmorel-35 marked this pull request as draft March 30, 2024 12:36
@mmorel-35 mmorel-35 marked this pull request as ready for review March 30, 2024 12:39
@blackpiglet blackpiglet requested a review from danfengliu April 1, 2024 02:44
@Lyndon-Li Lyndon-Li removed the request for review from danfengliu April 1, 2024 07:12
@sseago sseago merged commit facfb95 into vmware-tanzu:main Apr 15, 2024
66 checks passed
@mmorel-35 mmorel-35 deleted the azure-sdk-for-go branch April 15, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file has-changelog has-unit-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants