Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 7972: sync the backupPVC deletion in expose clean up #7973

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

Lyndon-Li
Copy link
Contributor

Fix issue #7972, sync the backupPVC deletion in expose clean up

@Lyndon-Li Lyndon-Li marked this pull request as ready for review July 3, 2024 06:53
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.84%. Comparing base (28d64c2) to head (7408dbd).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/exposer/generic_restore.go 0.00% 2 Missing ⚠️
pkg/exposer/csi_snapshot.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7973      +/-   ##
==========================================
+ Coverage   58.83%   58.84%   +0.01%     
==========================================
  Files         345      345              
  Lines       28795    28800       +5     
==========================================
+ Hits        16941    16947       +6     
+ Misses      10425    10424       -1     
  Partials     1429     1429              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li force-pushed the issue-fix-7972 branch 4 times, most recently from af79e96 to 4f20d40 Compare July 3, 2024 08:56
@Lyndon-Li Lyndon-Li requested a review from ywk253100 July 5, 2024 02:13
@ywk253100 ywk253100 merged commit 824bebb into vmware-tanzu:main Jul 5, 2024
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants