Create new ItemBlockAction (IBA) plugin type #8026
Conversation
| return nil, err | ||
| } | ||
|
|
||
| backupItemAction, ok := plugin.(ibav1.ItemBlockAction) |
There was a problem hiding this comment.
backup item action is a good name here?
itemBlockAction would be better?
There was a problem hiding this comment.
@mateusoliveira43 oops. Copy-and-paste error. Will fix.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8026 +/- ##
==========================================
- Coverage 58.88% 58.74% -0.15%
==========================================
Files 351 355 +4
Lines 29367 29561 +194
==========================================
+ Hits 17294 17365 +71
- Misses 10639 10757 +118
- Partials 1434 1439 +5 ☔ View full report in Codecov by Sentry. |
| @@ -77,6 +79,12 @@ type Manager interface { | |||
| // GetDeleteItemAction returns the delete item action plugin for name. | |||
| GetDeleteItemAction(name string) (velero.DeleteItemAction, error) | |||
|
|
|||
| // GetItemBlockActions returns all v1 ItemBlock action plugins. | |||
| GetItemBlockActions() ([]ibav1.ItemBlockAction, error) | |||
There was a problem hiding this comment.
this is a standard, but would suggest changing name here to avoid confusion, since 2 functions have very similar name
for example, changing here to GetAllItemBlockActions
There was a problem hiding this comment.
I'd rather not make this plugin inconsistent with every other plugin. Every other plugin type uses singular name to get one, and plural name to get all.
| protoibav1 "github.com/vmware-tanzu/velero/pkg/plugin/generated/itemblockaction/v1" | ||
| ) | ||
|
|
||
| // BackupItemActionPlugin is an implementation of go-plugin's Plugin |
There was a problem hiding this comment.
@mateusoliveira43 yes -- will fix this one too
sseago
force-pushed
the
itemblockaction
branch
2 times, most recently
from
6331d15 to
f62eeb1
Compare
Signed-off-by: Scott Seago <[email protected]>
|
I only have one comment. |
|
@blackpiglet Mock generation is covered here: https://velero.io/docs/main/code-standards/#mocks |
shubham-pampattiwar
merged commit 7811b9f
into
vmware-tanzu:main
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
First PR for #7900 (but not the complete feature)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.