Fix E2E StorageClass and VolumeSnapshotClass's install and delete logic #8407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
added
kind/changelog-not-required
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8407 +/- ##
==========================================
+ Coverage 58.95% 58.97% +0.02%
==========================================
Files 367 368 +1
Lines 38902 38973 +71
==========================================
+ Hits 22933 22986 +53
- Misses 14507 14524 +17
- Partials 1462 1463 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
blackpiglet
force-pushed
the
fix_storageclass
branch
10 times, most recently
from
05d3cd9 to
250b6df
Compare
blackpiglet
force-pushed
the
fix_storageclass
branch
from
250b6df to
497bf56
Compare
* Only install and uninstall SC and VSC once for default cluster. * Install and uninstall SC and VSC for standby cluster on migration case. * Refactor the StorageClass and VolumeSnapshotClass YAMLs. * Prettify the e2e_suite_test.go Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
force-pushed
the
fix_storageclass
branch
from
497bf56 to
e5354e1
Compare
reasonerjt
approved these changes
Nov 20, 2024
ywk253100
approved these changes
Nov 21, 2024
kaovilai
pushed a commit
to kaovilai/velero
that referenced
this pull request
Nov 24, 2024
Fix E2E StorageClass and VolumeSnapshotClass's install and delete logic Signed-off-by: Tiger Kaovilai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.