V0.9.7 cherrypicks #908
Merged
V0.9.7 cherrypicks #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to better reflect the intent of the user when node ports are specified explicitly (as opposed to being assigned by Kubernetes). The `last-applied-configuration` annotation added by `kubectl apply` is one such indicator we are now leveraging. We still default to omitting the node ports when the annotation is missing. Signed-off-by: Timo Reimann <[email protected]>
Signed-off-by: Shubheksha Jalan <[email protected]>
Signed-off-by: Shubheksha Jalan <[email protected]>
Signed-off-by: Shubheksha Jalan <[email protected]>
Signed-off-by: Michal Wieczorek <[email protected]>
Signed-off-by: Steve Kriss <[email protected]>
Signed-off-by: Marc Tudurí <[email protected]>
Signed-off-by: Steve Kriss <[email protected]>
Signed-off-by: Wayne Witzel III <[email protected]>
Signed-off-by: Steve Kriss <[email protected]>
wwitzel3
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #906