Drop volumes matching name ServiceAccountName-token-

[james-powis]

Continuation of #843 and #840

Addresses #909

There does not appear to be a test file for the restic_restore_action.go file so this is one of those "this should not break anything, I hope..." I just don't know enough about this project (or go testing in general) to create a test file from scratch.

To that end it compiles, and in go that is a good sign.

[skriss]

@james-powis I was thinking that this should go into pkg/restore/pod_action.go - since we want to remove these volume mounts from any initContainer, not just the restic one. In fact, the error you reported on slack reports an error with initContainer[1], which wouldn't be the restic one, since we always insert the restic one as the first, i.e. initContainer[0].

Can you confirm there was another non-restic initContainer on the workload you had issues with?

[james-powis]

@skriss You are right about that... And so it is, ready for your review, should be pretty easy it is nearly an identical duplication of the container volumeMount function and test.

[james-powis]

Also can I request a release after this is merged, even if it is a pre/beta release, I have a restore I need to perform....

[skriss]

LGTM, thanks @james-powis!

[skriss]

@carlisia PTAL as well

[carlisia]

👍 and thanks for adding a test!