✨ Single test target / workflow #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
force-pushed
the
feature/single-test-target
branch
2 times, most recently
from
94b58b9 to
30580d5
Compare
This patch simplifies the Makefile test targets so there is now a single test target named "test". There is also a single test workflow in GitHub, reducing the duplicate tests that would run as part of the old unit/integration test division.
akutz
force-pushed
the
feature/single-test-target
branch
from
30580d5 to
f371a90
Compare
|
bryanv
approved these changes
Apr 16, 2024
Why are we not failing the job if coverage drops below a threshold? |
Because adding a single test to v1a2 means the package is now covered, dropping our percentage from 70 to ~50. We had no tests in v1a2 before, but I added two for the two differences from v1a2 to v1a3. The right thing to do would be to add tests to cover all of v1a2 conversion, but since it's a 1-to-1 with v1a3 except for those two differences, it was a tall order for that reason. FWIW, on the topic of ignoring bits of a project for coverage, see:
Unfortunately there is no good way to exclude a single package from coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch simplifies the Makefile test targets so there is now a single test target named "test". There is also a single test workflow in GitHub, reducing the duplicate tests that would run as part of the old unit/integration test division.
This patch also updates the code coverage workflow to warn if coverage falls below the minimum instead of failing the job.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
Please add a release note if necessary: