Iac 778 backup on clean environment throws exception #155

mtopchieva · 2023-08-03T15:14:58Z

Checklist

Testing

Testing was done through a regular import of packages through the installer, with a flag in the 'environment.properties' file: 'vro_enable_backup=true'
Tests were performed by having a different set of packages and versions in the local VMware Aria Orchestrator instance, in order to validate that the highest available version per package name is backed up (in the 'vro' folder), or that if no versions are found for the package in vRO to back up, a message is logged that the back up for this package is skipped.

vmwclabot · 2023-08-03T15:15:01Z

@mtopchieva, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 4b783e1 must be signed by [email protected]
Commit a185fea must be signed by [email protected]
Commit 154f38d must be signed by [email protected]
Commit 5a08783 must be signed by [email protected]
Commit 6d972e8 must be signed by [email protected]
Commit 9f70a45 must be signed by [email protected]
Commit e56e332 must be signed by [email protected]

vmwclabot · 2023-08-08T09:19:29Z

@mtopchieva, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 3552fc1 must be signed by [email protected]

vmwclabot · 2023-08-08T09:19:29Z

@mtopchieva, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 3552fc1 must be signed by [email protected]

ivo-kotev

I think we need to re-evaluate the reason behind backing up only the last version

ivo-kotev · 2023-08-18T13:33:04Z

common/artifact-manager/src/main/java/com/vmware/pscoe/iac/artifact/VroPackageStore.java

@@ -178,8 +178,26 @@ public final List<Package> importAllPackages(final List<Package> vroPackages, fi
 				String backupFilePath = this.createBackupFilePath(pkg, currentDateTimeString, backupFilesDirectory);

 				try {
-					pkg.setFilesystemPath(backupFilePath);
-					restClient.exportPackage(pkg, dryrun, exportConfigAttributeValues, exportConfigSecureStringValues);
+					System.out.println("Package for back up: " + pkg.getFQName());


Can you please user the logger object to send information instead of system.out?

ivo-kotev · 2023-08-18T13:34:36Z

common/artifact-manager/src/main/java/com/vmware/pscoe/iac/artifact/VroPackageStore.java

+						restClient.exportPackage(highestVersionPac, dryrun, exportConfigAttributeValues, exportConfigSecureStringValues);
+
+					} else {
+						System.out.println("Package with name: " + pkg.getName() + " does not exist in vRO and backup is skipped.");


Can you please user the logger object to send information instead of system.out?

ivo-kotev · 2023-08-18T13:34:44Z

common/artifact-manager/src/main/java/com/vmware/pscoe/iac/artifact/VroPackageStore.java

+					} else {
+						System.out.println("Package with name: " + pkg.getName() + " does not exist in vRO and backup is skipped.");
+
+					}
 				} catch (Exception ex) {
 					String exceptionMessage = ex.getMessage();
 					System.out.println("ExceptionMessage: " + exceptionMessage);


Can you please user the logger object to send information instead of system.out?

ivo-kotev · 2023-08-18T13:34:50Z

common/artifact-manager/src/main/java/com/vmware/pscoe/iac/artifact/VroPackageStore.java

+			}
+		}
+
+		System.out.println("Highest version package to backup: " + highestVersionPac.getFQName());


Can you please user the logger object to send information instead of system.out?

ivo-kotev · 2023-08-18T13:39:09Z

common/artifact-manager/src/main/java/com/vmware/pscoe/iac/artifact/VroPackageStore.java

+	 * @param packages the collection of packages differring by version
+	 * @return the package with highest version
+	 */
+	private Package getHighestVersion(List<Package> packages) {


Why do we want to have only the latest versions backed up? We should be receiving backup of all versions, as Build Tools for VMware Aria - might have the cleanup flag enabled and delete some of the versions that we did not backed up.

Following the discussion in the jira issue, this is what was finally agreed.

vmwclabot · 2023-09-01T16:05:43Z

@mtopchieva, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 7ee9aa3 must be signed by [email protected]

vmwclabot · 2023-09-01T16:05:43Z

@mtopchieva, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 7ee9aa3 must be signed by [email protected]

mtopchieva · 2023-09-19T09:16:06Z

This issue IAC-778 has been assigned with new scope (to backup all versions of a package, not just the highest one). It must be added before merging the PR.

vmwclabot · 2023-11-14T16:45:18Z

@mtopchieva, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 36fc137 must be signed by [email protected]
Commit 28bbb22 must be signed by [email protected]

vmwclabot · 2023-11-14T16:45:18Z

@mtopchieva, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 36fc137 must be signed by [email protected]
Commit 28bbb22 must be signed by [email protected]

Signed-off-by: Aleksandar Kumanov <[email protected]>

…re-aria into IAC-778-backup-on-clean-environment-throws-exception Signed-off-by: Aleksandar Kumanov <[email protected]>

Signed-off-by: Aleksandar Kumanov <[email protected]>

ivo-kotev · 2023-11-21T07:40:19Z

common/artifact-manager/src/main/java/com/vmware/pscoe/iac/artifact/VroPackageStore.java

+					}
+
+					if (!samePackagesInDest.isEmpty()) {
+						List<Package> allCurrentPkgVersions = this.getPackages();


Is that going to retrieve all packages available in vRO (including the system packages) or just the packages matching the one we try to import?

it is going to retrieve all packages and all of their versions

ok, we need to update this - it needs to get all package versions, but only for the packages that we are trying to import (if existing packages are present on the env).

as example if we want to import com.vmware.pscoe.templates.buildtoolsforvmwareariasamples.xml-1.0.11-SNAPSHOT.package, then we should be exporting any package that starts with com.vmware.pscoe.templates.buildtoolsforvmwareariasamples.xml

PS: Keep in mind that in the package name we CAN have dash. (so we first remove any -SNAPSHOT text, then get the last dash in the string and extract the package name based on this)

Hi, my bad I mixed up the context with another ticket. It is backing up all versions (existing in the environment) of the packages we are about to import including the dependencies as well.

Signed-off-by: Aleksandar Kumanov <[email protected]>

mtopchieva requested a review from a team as a code owner August 3, 2023 15:14

vmwclabot added dco-required labels Aug 3, 2023

mtopchieva force-pushed the IAC-778-backup-on-clean-environment-throws-exception branch from e56e332 to 3cbcf1d Compare August 3, 2023 15:17

vmwclabot removed the dco-required label Aug 3, 2023

vmware deleted a comment from vmwclabot Aug 3, 2023

mtopchieva self-assigned this Aug 3, 2023

vmwclabot added dco-required labels Aug 8, 2023

mtopchieva force-pushed the IAC-778-backup-on-clean-environment-throws-exception branch from 3552fc1 to 030921a Compare August 8, 2023 09:27

vmwclabot removed dco-required labels Aug 8, 2023

ivo-kotev requested changes Aug 18, 2023

View reviewed changes

vmwclabot added dco-required labels Sep 1, 2023

mtopchieva force-pushed the IAC-778-backup-on-clean-environment-throws-exception branch from 60412c2 to 506aa52 Compare September 1, 2023 16:07

vmwclabot removed the dco-required label Sep 1, 2023

vmwclabot added dco-required labels Nov 14, 2023

akumanov-vmw force-pushed the IAC-778-backup-on-clean-environment-throws-exception branch from 28bbb22 to a34ccc1 Compare November 15, 2023 09:58

vmwclabot removed dco-required labels Nov 15, 2023

akumanov-vmw force-pushed the IAC-778-backup-on-clean-environment-throws-exception branch 2 times, most recently from fa8d894 to a01bb08 Compare November 15, 2023 14:30

IAC-778

8f3c697

Signed-off-by: Aleksandar Kumanov <[email protected]>

akumanov-vmw force-pushed the IAC-778-backup-on-clean-environment-throws-exception branch from a01bb08 to 8f3c697 Compare November 15, 2023 14:49

mtopchieva assigned akumanov-vmw Nov 15, 2023

updated changelog after release v2.36.0

b1637b2

Signed-off-by: Aleksandar Kumanov <[email protected]>

akumanov-vmw changed the base branch from main to IAC-799-Wrong-unix-file-path-separators-when-creating-backup-path November 17, 2023 12:59

akumanov-vmw changed the base branch from IAC-799-Wrong-unix-file-path-separators-when-creating-backup-path to main November 17, 2023 12:59

akumanov-vmw added 3 commits November 17, 2023 15:32

Merge branch 'main' of https://github.com/vmware/build-tools-for-vmwa…

675f9cb

…re-aria into IAC-778-backup-on-clean-environment-throws-exception Signed-off-by: Aleksandar Kumanov <[email protected]>

fix new release.md

e819cd3

Signed-off-by: Aleksandar Kumanov <[email protected]>

lint - remove blank lines

4e82c89

Signed-off-by: Aleksandar Kumanov <[email protected]>

ivo-kotev reviewed Nov 21, 2023

View reviewed changes

akumanov-vmw added 2 commits November 22, 2023 10:37

backup all versions of 'PASS' package

16ee970

Signed-off-by: Aleksandar Kumanov <[email protected]>

change in logger.info message

ea08b9e

Signed-off-by: Aleksandar Kumanov <[email protected]>

vmware deleted a comment from mtopchieva Nov 24, 2023

ivo-kotev approved these changes Nov 24, 2023

View reviewed changes

akumanov-vmw merged commit e3bea21 into main Nov 24, 2023
11 checks passed

VenelinBakalov deleted the IAC-778-backup-on-clean-environment-throws-exception branch November 1, 2024 10:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Iac 778 backup on clean environment throws exception #155

Iac 778 backup on clean environment throws exception #155

mtopchieva commented Aug 3, 2023 •

edited by akumanov-vmw

Loading

vmwclabot commented Aug 3, 2023

vmwclabot commented Aug 8, 2023

vmwclabot commented Aug 8, 2023

ivo-kotev left a comment

ivo-kotev Aug 18, 2023

ivo-kotev Aug 18, 2023

ivo-kotev Aug 18, 2023

ivo-kotev Aug 18, 2023

ivo-kotev Aug 18, 2023

mtopchieva Sep 1, 2023

vmwclabot commented Sep 1, 2023

vmwclabot commented Sep 1, 2023

mtopchieva commented Sep 19, 2023

vmwclabot commented Nov 14, 2023

vmwclabot commented Nov 14, 2023

ivo-kotev Nov 21, 2023

akumanov-vmw Nov 21, 2023

ivo-kotev Nov 21, 2023

akumanov-vmw Nov 21, 2023

Iac 778 backup on clean environment throws exception #155

Iac 778 backup on clean environment throws exception #155

Conversation

mtopchieva commented Aug 3, 2023 • edited by akumanov-vmw Loading

Checklist

Testing

vmwclabot commented Aug 3, 2023

vmwclabot commented Aug 8, 2023

vmwclabot commented Aug 8, 2023

ivo-kotev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vmwclabot commented Sep 1, 2023

vmwclabot commented Sep 1, 2023

mtopchieva commented Sep 19, 2023

vmwclabot commented Nov 14, 2023

vmwclabot commented Nov 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mtopchieva commented Aug 3, 2023 •

edited by akumanov-vmw

Loading