Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IAC-797 Improved default content.yaml archetypes for vRA #170

Merged
merged 5 commits into from
Nov 14, 2023
Merged

IAC-797 Improved default content.yaml archetypes for vRA #170

merged 5 commits into from
Nov 14, 2023

Conversation

imihov1988
Copy link
Contributor

@imihov1988 imihov1988 commented Sep 19, 2023 •
edited by joroaf
Loading

…h/pull

Description

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added relevant error handling and logging messages to help troubleshooting
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated CHANGELOG.md with a short summary of the changes introduced
  • I have tested against live environment, if applicable
  • I have added relevant usage information (As-built)
  • Any structure and/or content vRA-NG improvements are synchronized with vra-ng and ts-vra-ng archetypes
  • Every new or updated Installer property is documented in docs/archive/doc/markdown/use-bundle-installer.md
  • Dependencies in pom.xml are up-to-date
  • My changes have been rebased and squashed to the minimal number of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Release Notes

Related issues and PRs

@imihov1988 imihov1988 requested a review from a team as a code owner September 19, 2023 07:28
@vmwclabot
Copy link
Member

@imihov1988, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@imihov1988, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Michaelpalacce
Michaelpalacce reviewed Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@Michaelpalacce Michaelpalacce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog + release.md

maven/archetypes/ts-vra-ng/src/main/resources/archetype-resources/vra/content.yaml
@@ -27,7 +27,8 @@
# - policy name 2

blueprint:
subscription:
- Volume
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets set this to [] as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Michaelpalacce it doesn't work with empty blueprints as we have tested with @joroaf the newly created project from the archetype

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imihov1988 You get an error when pulling empty blueprints? really?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Michaelpalacce Yes, it was not erroring out when trying to build it.

maven/archetypes/vra-ng/src/main/resources/archetype-resources/content.yaml
@@ -27,7 +27,8 @@
# - policy name 2

blueprint:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applicable here too

ivo-kotev
ivo-kotev reviewed Sep 19, 2023
View reviewed changes
maven/archetypes/ts-vra-ng/src/main/resources/archetype-resources/vra/content.yaml Outdated
policy:
content-sharing:
content-sharing: []
lease: []
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess lease and day2actions are still not existing, so let's not confuse people that this can be used until implemented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivo-kotev Ok, I removed them.

@vmwclabot
Copy link
Member

@imihov1988, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@imihov1988, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@joroaf joroaf self-requested a review September 20, 2023 17:01
Michaelpalacce
Michaelpalacce requested changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@Michaelpalacce Michaelpalacce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes needed

Michaelpalacce
Michaelpalacce previously requested changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@Michaelpalacce Michaelpalacce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog + Release.md please

maven/archetypes/ts-vra-ng/src/main/resources/archetype-resources/vra/content.yaml
@@ -27,7 +27,8 @@
# - policy name 2

blueprint:
subscription:
- Volume
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imihov1988 You get an error when pulling empty blueprints? really?

@vmwclabot
Copy link
Member

@imihov1988, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@imihov1988, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@joroaf joroaf dismissed Michaelpalacce’s stale review November 14, 2023 12:14

resolving and merging

@joroaf joroaf changed the title Fixed default content.yaml template for vRA to be working for vRA pus… IAC-797 Improved default content.yaml archetypes for vRA Nov 14, 2023
@vmwclabot
Copy link
Member

@imihov1988, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@imihov1988, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@VenelinBakalov VenelinBakalov self-requested a review November 14, 2023 13:22
@VenelinBakalov VenelinBakalov merged commit d16df7c into main Nov 14, 2023
@VenelinBakalov VenelinBakalov deleted the fix-vra-content-yaml-template branch November 14, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivo-kotev ivo-kotev ivo-kotev left review comments

@joroaf joroaf joroaf approved these changes

@VenelinBakalov VenelinBakalov VenelinBakalov approved these changes

@Michaelpalacce Michaelpalacce Michaelpalacce left review comments

Assignees
No one assigned
Labels
dco-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@imihov1988 @vmwclabot @ivo-kotev @joroaf @Michaelpalacce @VenelinBakalov