Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vrdt,packages] (#427) Restore missing exec package required for Run vRO Action VScode command #435

Merged
merged 6 commits into from
Oct 1, 2024
Merged

[vrdt,packages] (#427) Restore missing exec package required for Run vRO Action VScode command #435

merged 6 commits into from
Oct 1, 2024

Conversation

bcpmihail
Copy link
Contributor

@bcpmihail bcpmihail commented Oct 1, 2024 •
edited by VenelinBakalov
Loading

Description

Restored the missing exec module in packages and its dependency in the repository module.

Checklist

  • I have added relevant error handling and logging messages to help troubleshooting
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation, relevant usage information (if applicable)
  • I have updated the PR title with affected component, related issue number and a short summary of the changes introduced
  • I have added labels for implementation kind (kind/) and version type (version/)
  • I have tested against live environment, if applicable
  • I have synced any structure and/or content vRA-NG improvements with vra-ng and ts-vra-ng archetypes (if applicable)
  • I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
  • I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Builds successfully, 'com.vmware.pscoe.o11n:exec' package is generated.
Tested successfully in VRDT by @VenelinBakalov .

Related issues and PRs

#427

@bcpmihail
chore: [427] reintroduced exec module
4b71c84 
Signed-off-by: Mihail Penchev (c) <[email protected]>
@bcpmihail
chore: [427] using latest version of parent module
c1c4490 
Signed-off-by: Mihail Penchev (c) <[email protected]>
@bcpmihail
chore: [427] Merged origin/main into bugfix/427-missing-exec-package
886e649 
Signed-off-by: Mihail Penchev (c) <[email protected]>
@bcpmihail
fix: [427] Added missing flatten plugin in exec pom
d2815d6 
Added omitted exec dependency in repository pom
Added exec module in packages pom

Signed-off-by: Mihail Penchev (c) <[email protected]>
@bcpmihail
chore: [427] Merged latest origin/main into bugfix/427-missing-exec-p…
735c5be 
…ackage

Signed-off-by: Mihail Penchev (c) <[email protected]>
@bcpmihail bcpmihail added kind/bug Something isn't working area/vrdt Relates to vRealize Developer Tools version/minor Introduces a non-breaking feature or change labels Oct 1, 2024
@bcpmihail bcpmihail self-assigned this Oct 1, 2024
@bcpmihail bcpmihail requested a review from a team as a code owner October 1, 2024 07:06
@bcpmihail bcpmihail linked an issue Oct 1, 2024 that may be closed by this pull request
Missing exec package results in failure to execute an action in VScode #427
Closed
@VenelinBakalov VenelinBakalov changed the title [vrdt] (#427) Restored missing exec package [vrdt,packages] (#427) Restored missing exec package Oct 1, 2024
@VenelinBakalov VenelinBakalov changed the title [vrdt,packages] (#427) Restored missing exec package [vrdt,packages] (#427) Restore missing exec package required for Run vRO Action VScode command Oct 1, 2024
@bcpmihail
docs: [427] Updated Release.md
0efa811 
Signed-off-by: Mihail Penchev (c) <[email protected]>
@VenelinBakalov
Copy link
Collaborator

image image image image

Working both with a successful and failing workflow. Pending to open an issue in vRDT github because currently no execution logs are shown in VS code and are expected to be seen there.

@VenelinBakalov VenelinBakalov added version/patch The change is a non-breaking bugfix and removed version/minor Introduces a non-breaking feature or change labels Oct 1, 2024
@VenelinBakalov VenelinBakalov merged commit 5eff382 into main Oct 1, 2024
10 checks passed
@VenelinBakalov VenelinBakalov deleted the bugfix/427-missing-exec-package branch October 1, 2024 08:26
This was referenced Oct 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VenelinBakalov VenelinBakalov VenelinBakalov approved these changes

@Michaelpalacce Michaelpalacce Awaiting requested review from Michaelpalacce

Assignees

@bcpmihail bcpmihail

Labels
area/vrdt Relates to vRealize Developer Tools kind/bug Something isn't working version/patch The change is a non-breaking bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing exec package results in failure to execute an action in VScode
2 participants
@bcpmihail @VenelinBakalov