Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[artifact-manager,maven,package-installer,vro-types] (#306) Remove support for vRA and vRO 7 #453

Merged
merged 16 commits into from
Nov 1, 2024
Merged

[artifact-manager,maven,package-installer,vro-types] (#306) Remove support for vRA and vRO 7 #453

merged 16 commits into from
Nov 1, 2024

Conversation

Michaelpalacce
Copy link
Collaborator

@Michaelpalacce Michaelpalacce commented Oct 14, 2024 •
edited
Loading

Description

Checklist

  • I have added relevant error handling and logging messages to help troubleshooting
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation, relevant usage information (if applicable)
  • I have updated the PR title with affected component, related issue number and a short summary of the changes introduced
  • I have added labels for implementation kind (kind/) and version type (version/)
  • I have tested against live environment, if applicable
  • I have synced any structure and/or content vRA-NG improvements with vra-ng and ts-vra-ng archetypes (if applicable)
  • I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
  • I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Release Notes

Related issues and PRs

#306

@github-actions github-actions bot added the kind/refactor Refactoring of existing features label Oct 14, 2024
@VenelinBakalov VenelinBakalov added the version/major Introduces a breaking change label Oct 14, 2024
@VenelinBakalov VenelinBakalov changed the title [*] (#306) Removed vra and vro7 [artifact-manager,maven,package-installer,vro-types] (#306) Remove support for vRA and vRO 7 Oct 14, 2024
@VenelinBakalov
Copy link
Collaborator

You know I will need to ask for release.md :D

@VenelinBakalov VenelinBakalov added area/artifact-manager Relates to the `artifact-manager` maven module area/vro-types Relates to changes to the type definitions area/installer Relates to the solution installer area/actions Relates to the `actions` archetype area/maven Relates to maven changes area/aria lang/java Related to Java Code labels Oct 14, 2024
@VenelinBakalov VenelinBakalov added this to the 3.0.0 milestone Oct 14, 2024
@github-actions github-actions bot added the kind/enhancement Enhancement or improvement of existing features label Oct 14, 2024
@Michaelpalacce
Copy link
Collaborator Author

You know I will need to ask for release.md :D

@VenelinBakalov it's still a Draft PR 😄

@Michaelpalacce Michaelpalacce self-assigned this Oct 15, 2024
@Michaelpalacce
chore(build):Using a fork for the samples to see if it builds
8bcf4ef 
The fork will be merged to main when the time comes
Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
style(lint): Added documentation
9b2dbf1 
Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
docs: Release.md
2c43c65 
Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce Michaelpalacce marked this pull request as ready for review October 15, 2024 12:17
@Michaelpalacce Michaelpalacce requested a review from a team as a code owner October 15, 2024 12:17
@Michaelpalacce Michaelpalacce removed this from the 3.0.0 milestone Oct 16, 2024
VenelinBakalov
VenelinBakalov requested changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@VenelinBakalov VenelinBakalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor questions and we need merge conflicts resolved and the aria samples fork merged

@VenelinBakalov
Copy link
Collaborator

Related samples PR: vmware-samples/build-tools-for-vmware-aria-samples#2

@VenelinBakalov VenelinBakalov mentioned this pull request Oct 25, 2024
Merged
@Michaelpalacce @VenelinBakalov
Update docs/versions/latest/Release.md
cf4e35b 
Co-authored-by: Venelin Bakalov <[email protected]>
Signed-off-by: Stefan Genov <[email protected]>
@vmwclabot
Copy link
Member

@Michaelpalacce, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@Michaelpalacce, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@Michaelpalacce @VenelinBakalov
Update docs/versions/latest/Release.md
2512219 
Co-authored-by: Venelin Bakalov <[email protected]>
Signed-off-by: Stefan Genov <[email protected]>
@vmwclabot
Copy link
Member

@Michaelpalacce, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@Michaelpalacce, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@Michaelpalacce
Merge branch 'main' of https://github.com/vmware/build-tools-for-vmwa…
2f89988 
…re-aria into refactor/306-deprecate-vra-and-vro

Signed-off-by: Stefan Genov <[email protected]>
@vmwclabot
Copy link
Member

@Michaelpalacce, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@Michaelpalacce, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@Michaelpalacce
build: removed unused dep
712bcee 
Signed-off-by: Stefan Genov <[email protected]>
@vmwclabot
Copy link
Member

@Michaelpalacce, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@Michaelpalacce, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@Michaelpalacce, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@Michaelpalacce, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@Michaelpalacce Michaelpalacce merged commit b06c33b into main Nov 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VenelinBakalov VenelinBakalov VenelinBakalov approved these changes

Assignees

@Michaelpalacce Michaelpalacce

Labels
area/actions Relates to the `actions` archetype area/aria area/artifact-manager Relates to the `artifact-manager` maven module area/installer Relates to the solution installer area/maven Relates to maven changes area/vro-types Relates to changes to the type definitions kind/enhancement Enhancement or improvement of existing features kind/refactor Refactoring of existing features lang/java Related to Java Code version/major Introduces a breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Michaelpalacce @VenelinBakalov @vmwclabot