Message size check for UDP transport #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
- Coverage 81.30% 81.14% -0.16%
==========================================
Files 13 13
Lines 1487 1496 +9
==========================================
+ Hits 1209 1214 +5
- Misses 186 191 +5
+ Partials 92 91 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
srikartati
changed the title
srikartati
force-pushed
the
udp_check
branch
2 times, most recently
from
887a1c0 to
c95b4a6
Compare
zyiou
reviewed
Dec 2, 2020
pkg/exporter/process.go
Outdated
| return 0, fmt.Errorf("set size exceeds max socket size") | ||
| if ep.connToCollector.LocalAddr().Network() == "tcp" { | ||
| if msgLen > entities.MaxTcpSocketMsgSize { | ||
| return 0, fmt.Errorf("TCP transport: set size exceeds max socket buffer size") |
pkg/exporter/process.go
Outdated
| } | ||
| } else { | ||
| if msgLen > ep.pathMTU { | ||
| return 0, fmt.Errorf("UDP transport: set size exceeds max pathMTU (set as %v)", ep.pathMTU) |
zyiou
reviewed
Dec 2, 2020
| dataSet.AddRecord(elements, templateID) | ||
| } | ||
| bytesSent, err = exporter.SendSet(dataSet) | ||
| assert.Error(t, err) |
There was a problem hiding this comment.
I tried to log the error here. the error message is could not send the complete message on the connection instead of exceeding maximum size. Not sure whether we can test it here since 65535 is rather large and current msgLen for 10000 records is only 14484
There was a problem hiding this comment.
Good catch with the error. Each data record is around ~8 bytes, so the number of data records added is fine but uint16 casting in set.GetBufferLen is causing the issue. Fixed it.
pkg/exporter/process_test.go
Outdated
| // 28 is the size of the IPFIX message including all headers (20 bytes) | ||
| assert.Equal(t, 28, bytesSent) | ||
| assert.Equal(t, dataRecBytes, <-buffCh) | ||
| assert.Equal(t, uint32(1), exporter.seqNumber) | ||
|
|
||
| // Create data set with multiple data records to test invalid message length | ||
| // logic for |
srikartati
force-pushed
the
udp_check
branch
2 times, most recently
from
b63d712 to
db1b396
Compare
Added a path MTU config parameter for InitExportingProcess function. For UDP transport, based on path MTU parameter, we make a decision on the message size. This is optional parameter for TCP transport; TCP supports max socket buffer size (65535).
zyiou
pushed a commit
to zyiou/go-ipfix
that referenced
this pull request
Feb 5, 2021
Added a path MTU config parameter for InitExportingProcess function. For UDP transport, based on path MTU parameter, we make a decision on the message size. This is optional parameter for TCP transport; TCP supports max socket buffer size (65535).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a path MTU config parameter for InitExportingProcess function.
For UDP transport, based on path MTU parameter, we make a decision on
the message size. This is optional parameter for TCP transport; TCP
supports max socket buffer size (65535).
Cleaned up AddSetAndSendMsg function a bit as well.
This PR is on top of PR #91. It will be checked in after that PR. Please look for separate commit when reviewing.